Use the screen info's scale factor to scale the drag image

Use the screen info's scale factor to scale the drag image

This also remove WebView::deviceScaleFactor() and moved to RenderView because it's no longer necessary in Blink.

BUG=485650
Committed: https://crrev.com/129b75edbd8bfebd325a0c826517a2ea4cff3d24
Cr-Commit-Position: refs/heads/master@{#369376}

[oshima, 2016-01-08 22:06:32]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 22:07:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572703002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572703002/1

[oshima, 2016-01-08 22:23:58]

Description was changed from

==========
Remove WebView::deviceScaleFactor()

BUG=485650
==========

to

==========
Use the screen info's scale factor to scale the drag image

This also remove WebView::deviceScaleFactor()

BUG=485650
==========

[commit-bot: I haz the power, 2016-01-08 22:38:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 22:38:47]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[oshima, 2016-01-11 20:45:11]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-11 20:47:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572703002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572703002/20001

[commit-bot: I haz the power, 2016-01-11 22:18:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 22:18:30]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-01-13 02:39:09]

oshima@chromium.org changed reviewers:
+ jbroman@chromium.org

[oshima, 2016-01-13 02:39:09]

Hi, can you review this change? You seems to be the most recent person who made
non trivial change.

We're eliminating "deviceScaleFactor" from Blink (see bug), and the blink code
that absolutely need to use it should use WebScreenInfo.

[oshima, 2016-01-13 02:39:59]

On 2016/01/13 02:39:09, oshima wrote:
> Hi, can you review this change? You seems to be the most recent person who
made
> non trivial change.

I meant "non trivial change in DragClientImpl.cpp".

> We're eliminating "deviceScaleFactor" from Blink (see bug), and the blink code
> that absolutely need to use it should use WebScreenInfo.

[jbroman, 2016-01-13 15:35:13]

DragClientImpl lgtm (but I'm not sure I'm a good reviewer for the rest of the
changes; maybe someone familiar with zooming, like bokan, would be a good person
to have a look).

Would you also mind changing the CL description? Currently it buries the lede:
the change does a number of things unrelated to using the WebScreenInfo scale
factor for the drag image.

https://codereview.chromium.org/1572703002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/DragClientImpl.cpp (right):

https://codereview.chromium.org/1572703002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/DragClientImpl.cpp:36: #include
"core/page/ChromeClient.h"
nit: Why this include? You don't seem to have added a use of ChromeClient.

[oshima, 2016-01-13 18:18:15]

Description was changed from

==========
Use the screen info's scale factor to scale the drag image

This also remove WebView::deviceScaleFactor()

BUG=485650
==========

to

==========
Use the screen info's scale factor to scale the drag image

This also remove WebView::deviceScaleFactor() because it's no longer necessary.

BUG=485650
==========

[oshima, 2016-01-13 18:18:33]

Description was changed from

==========
Use the screen info's scale factor to scale the drag image

This also remove WebView::deviceScaleFactor() because it's no longer necessary.

BUG=485650
==========

to

==========
Use the screen info's scale factor to scale the drag image

This also remove WebView::deviceScaleFactor() and moved to RenderView because
it's no longer necessary in Blink.

BUG=485650
==========

[oshima, 2016-01-13 18:19:43]

thanks, I was planning to add owners once I've got ok for DragImageImpl change.

I updated the description why this CL also removes deviceScaleFactor()

https://codereview.chromium.org/1572703002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/DragClientImpl.cpp (right):

https://codereview.chromium.org/1572703002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/DragClientImpl.cpp:36: #include
"core/page/ChromeClient.h"
On 2016/01/13 15:35:13, jbroman wrote:
> nit: Why this include? You don't seem to have added a use of ChromeClient.

m_webView->client() returns ChromeClient

[dcheng, 2016-01-13 18:20:53]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-01-13 18:20:53]

https://codereview.chromium.org/1572703002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/DragClientImpl.cpp (right):

https://codereview.chromium.org/1572703002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/DragClientImpl.cpp:36: #include
"core/page/ChromeClient.h"
On 2016/01/13 at 18:19:43, oshima wrote:
> On 2016/01/13 15:35:13, jbroman wrote:
> > nit: Why this include? You don't seem to have added a use of ChromeClient.
> 
> m_webView->client() returns ChromeClient

This returns WebViewClient, not ChromeClient.

[oshima, 2016-01-13 18:39:10]

On 2016/01/13 18:20:53, dcheng wrote:
>
https://codereview.chromium.org/1572703002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/web/DragClientImpl.cpp (right):
> 
>
https://codereview.chromium.org/1572703002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/web/DragClientImpl.cpp:36: #include
> "core/page/ChromeClient.h"
> On 2016/01/13 at 18:19:43, oshima wrote:
> > On 2016/01/13 15:35:13, jbroman wrote:
> > > nit: Why this include? You don't seem to have added a use of ChromeClient.
> > 
> > m_webView->client() returns ChromeClient
> 
> This returns WebViewClient, not ChromeClient.

Oh, sorry my mistake. Fixed.

[oshima, 2016-01-13 23:03:41]

oshima@chromium.org changed reviewers:
+ pfeldman@chromium.org

[oshima, 2016-01-13 23:03:41]

pfeldman@ -> owners

[pfeldman, 2016-01-13 23:26:13]

lgtm

[oshima, 2016-01-13 23:47:59]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-01-13 23:48:00]

The patchset sent to the CQ was uploaded after l-g-t-m from jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1572703002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-01-13 23:51:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572703002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572703002/40001

[commit-bot: I haz the power, 2016-01-14 01:58:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 01:58:32]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
  linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[oshima, 2016-01-14 02:13:24]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2016-01-14 02:18:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572703002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572703002/40001

[commit-bot: I haz the power, 2016-01-14 04:25:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 04:25:38]

Exceeded global retry quota

[oshima, 2016-01-14 07:54:19]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2016-01-14 07:54:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572703002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572703002/40001

[commit-bot: I haz the power, 2016-01-14 09:15:21]

Description was changed from

==========
Use the screen info's scale factor to scale the drag image

This also remove WebView::deviceScaleFactor() and moved to RenderView because
it's no longer necessary in Blink.

BUG=485650
==========

to

==========
Use the screen info's scale factor to scale the drag image

This also remove WebView::deviceScaleFactor() and moved to RenderView because
it's no longer necessary in Blink.

BUG=485650
==========

[commit-bot: I haz the power, 2016-01-14 09:15:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-14 09:16:33]

Description was changed from

==========
Use the screen info's scale factor to scale the drag image

This also remove WebView::deviceScaleFactor() and moved to RenderView because
it's no longer necessary in Blink.

BUG=485650
==========

to

==========
Use the screen info's scale factor to scale the drag image

This also remove WebView::deviceScaleFactor() and moved to RenderView because
it's no longer necessary in Blink.

BUG=485650

Committed: https://crrev.com/129b75edbd8bfebd325a0c826517a2ea4cff3d24
Cr-Commit-Position: refs/heads/master@{#369376}
==========

[commit-bot: I haz the power, 2016-01-14 09:16:33]

Patchset 3 (id:??) landed as
https://crrev.com/129b75edbd8bfebd325a0c826517a2ea4cff3d24
Cr-Commit-Position: refs/heads/master@{#369376}