Add popup layout tests with device scale factor

Add popup layout tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously
* data-suggestion-picker test is temporarily marked as failure as
  bots generate slightly different images. I'll investigate it in a separate CL.
* moved and enabled popup tests in fast/hidpi/static
* Added VirtualTestSuite for dsf=2, dsf=1.5 and dsf=2 with zooming option.

BUG=567837
Committed: https://crrev.com/c059194cf382b17fc5ef02b688b5ac7013f855b3
Cr-Commit-Position: refs/heads/master@{#368951}

[oshima, 2016-01-08 18:31:58]

Description was changed from

==========
Fix LayoutTest
* allow --force-device-scale-factor in LayoutTest
* fix popup position BUG=

BUG=567837
==========

to

==========
Add popup tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* fix popup position BUG=

BUG=567837
==========

[oshima, 2016-01-08 18:49:52]

Description was changed from

==========
Add popup tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* fix popup position BUG=

BUG=567837
==========

to

==========
Add hdpi popup tests

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* fix popup position BUG=

BUG=567837
==========

[oshima, 2016-01-08 18:50:11]

Patchset #2 (id:20001) has been deleted

[oshima, 2016-01-08 18:52:23]

oshima@chromium.org changed reviewers:
+ mkwst@chromium.org, noel@chromium.org, wkorman@chromium.org

[oshima, 2016-01-08 18:53:24]

Patchset #2 (id:40001) has been deleted

[oshima, 2016-01-08 18:53:30]

Patchset #1 (id:1) has been deleted

[oshima, 2016-01-08 18:54:40]

Description was changed from

==========
Add hdpi popup tests

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* fix popup position BUG=

BUG=567837
==========

to

==========
Add popup tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously

BUG=567837
==========

[oshima, 2016-01-08 18:54:40]

oshima@chromium.org changed reviewers:
- mkwst@chromium.org, noel@chromium.org, wkorman@chromium.org

[oshima, 2016-01-08 18:54:49]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 18:55:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571833002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571833002/60001

[oshima, 2016-01-08 21:16:12]

Description was changed from

==========
Add popup tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously

BUG=567837
==========

to

==========
Add popup tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously
* data-suggestion-picker test is temporarily marked as failure as
  bots generates slightly different images. I'll investigate it in a separate
CL.

BUG=567837
==========

[oshima, 2016-01-08 21:16:12]

oshima@chromium.org changed reviewers:
+ tkent@chromium.org

[oshima, 2016-01-08 21:18:06]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2016-01-08 21:18:26]

Description was changed from

==========
Add popup tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously
* data-suggestion-picker test is temporarily marked as failure as
  bots generates slightly different images. I'll investigate it in a separate
CL.

BUG=567837
==========

to

==========
Add popup tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously
* data-suggestion-picker test is temporarily marked as failure as
  bots generate slightly different images. I'll investigate it in a separate CL.

BUG=567837
==========

[commit-bot: I haz the power, 2016-01-08 21:19:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571833002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571833002/80001

[oshima, 2016-01-08 21:34:58]

Patchset #1 (id:60001) has been deleted

[oshima, 2016-01-08 21:35:02]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2016-01-08 21:35:46]

Description was changed from

==========
Add popup tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously
* data-suggestion-picker test is temporarily marked as failure as
  bots generate slightly different images. I'll investigate it in a separate CL.

BUG=567837
==========

to

==========
Add popup tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously
* data-suggestion-picker test is temporarily marked as failure as
  bots generate slightly different images. I'll investigate it in a separate CL.
* moved and enabled popup tests in fast/hidpi/static
* Added VirtualTestSuite for dsf=2, dsf=1.5 and dsf=2 with zooming option.

BUG=567837
==========

[commit-bot: I haz the power, 2016-01-08 21:36:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571833002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571833002/100001

[oshima, 2016-01-08 22:09:16]

oshima@chromium.org changed reviewers:
+ pfeldman@chromium.org

[oshima, 2016-01-08 22:15:53]

I abandoned the previous approach (https://codereview.chromium.org/1555163002/).
Instead, we decided to use VirtualTestSuite. PTAL

tkent/pfeldman -> owners review

noel@ -> fyi, but review welcome.

[oshima, 2016-01-08 22:27:56]

https://codereview.chromium.org/1571833002/diff/100001/content/renderer/rende...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/1571833002/diff/100001/content/renderer/rende...
content/renderer/render_view_impl.cc:3733: LOG(ERROR) << "DSF=" <<
webview()->deviceScaleFactor();
this is deleted in next patch.

https://codereview.chromium.org/1571833002/diff/100001/content/shell/renderer...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/1571833002/diff/100001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:774: float scale =
render_view()->GetDeviceScaleFactorForTest();
FYI: I added new method to get scale factor because because
WebView::deviceScaleFactor() will soon be deleted.
(https://codereview.chromium.org/1572703002/)

https://codereview.chromium.org/1571833002/diff/100001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:777: }
Spacing is fixed in the next patch.

[Noel Gordon, 2016-01-09 03:23:50]

noel@chromium.org changed reviewers:
+ noel@chromium.org

[Noel Gordon, 2016-01-09 03:23:51]

The following files are empty: intentional?

third_party/WebKit/LayoutTests/virtual/scalefactor150/fast/hidpi/static/README.txt
third_party/WebKit/LayoutTests/virtual/scalefactor200/fast/hidpi/static/README.txt

I'd not normally add layout test results and images to a Blink CL.  I suppose it
helps reviewers see what is going on.  Anyho, review TODO item: please ensure
all tests are marked [ NeedsRebasleine ].

https://codereview.chromium.org/1571833002/diff/100001/content/renderer/rende...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/1571833002/diff/100001/content/renderer/rende...
content/renderer/render_view_impl.cc:3733: LOG(ERROR) << "DSF=" <<
webview()->deviceScaleFactor();
On 2016/01/08 22:27:55, oshima wrote:
> this is deleted in next patch.

Acknowledged.

https://codereview.chromium.org/1571833002/diff/100001/content/shell/renderer...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/1571833002/diff/100001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:774: float scale =
render_view()->GetDeviceScaleFactorForTest();
On 2016/01/08 22:27:56, oshima wrote:
> FYI: I added new method to get scale factor because because
> WebView::deviceScaleFactor() will soon be deleted.
> (https://codereview.chromium.org/1572703002/)

Add FIXME/TODO.

https://codereview.chromium.org/1571833002/diff/120001/components/test_runner...
File components/test_runner/test_runner.cc (right):

https://codereview.chromium.org/1571833002/diff/120001/components/test_runner...
components/test_runner/test_runner.cc:1707: base::CommandLine* command_line =
base::CommandLine::ForCurrentProcess();
Define a static TestRuner::deviceScaleFactorForTest routine and put this code in
it.

https://codereview.chromium.org/1571833002/diff/120001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/VirtualTestSuites (right):

https://codereview.chromium.org/1571833002/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/VirtualTestSuites:196: {
Prefixing helped fix the test name issue.  Seems fine.

https://codereview.chromium.org/1571833002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/testing/Internals.cpp (left):

https://codereview.chromium.org/1571833002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/testing/Internals.cpp:211:
page->setDeviceScaleFactor(1);
Yes!

[Noel Gordon, 2016-01-09 03:37:56]

Description was changed from

==========
Add popup tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously
* data-suggestion-picker test is temporarily marked as failure as
  bots generate slightly different images. I'll investigate it in a separate CL.
* moved and enabled popup tests in fast/hidpi/static
* Added VirtualTestSuite for dsf=2, dsf=1.5 and dsf=2 with zooming option.

BUG=567837
==========

to

==========
Add popup layout tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously
* data-suggestion-picker test is temporarily marked as failure as
  bots generate slightly different images. I'll investigate it in a separate CL.
* moved and enabled popup tests in fast/hidpi/static
* Added VirtualTestSuite for dsf=2, dsf=1.5 and dsf=2 with zooming option.

BUG=567837
==========

[oshima, 2016-01-09 22:25:30]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-09 22:25:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571833002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571833002/140001

[commit-bot: I haz the power, 2016-01-09 23:31:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-09 23:31:36]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-01-11 18:52:12]

PTAL

>
third_party/WebKit/LayoutTests/virtual/scalefactor150/fast/hidpi/static/README.txt
>
third_party/WebKit/LayoutTests/virtual/scalefactor200/fast/hidpi/static/README.txt

They're not empty. For some reason, git cl upload treat them as binary file,
probably
because it misunderstands that they're rename of binary files. 
(https://codereview.chromium.org/download/issue1571833002_140001_150052.diff)


"git show" displays the text diff

-----
diff --git
a/third_party/WebKit/LayoutTests/virtual/scalefactor150/fast/hidpi/static/README.txt
b/third_party/WebKit/LayoutTests/virtual/scalefactor150/fast/hidpi/static/README.txt
new file mode 100644
index 0000000..ff64360
--- /dev/null
+++
b/third_party/WebKit/LayoutTests/virtual/scalefactor150/fast/hidpi/static/README.txt
@@ -0,0 +1,2 @@
+# This suite runs the tests in fast/hidpi/static with
+# --force-device-scale-factor=1.5
diff --git
a/third_party/WebKit/LayoutTests/virtual/scalefactor200/fast/hidpi/static/README.txt
b/third_party/WebKit/LayoutTests/virtual/scalefactor200/fast/hidpi/static/README.txt
new file mode 100644
index 0000000..530ac2d
--- /dev/null
+++
b/third_party/WebKit/LayoutTests/virtual/scalefactor200/fast/hidpi/static/README.txt
@@ -0,0 +1,2 @@
+# This suite runs the tests in fast/hidpi/static with
+# --force-device-scale-factor=2
----

I tried adjusting similarity but no luck. Any advice?


> I'd not normally add layout test results and images to a Blink CL.  I suppose
it
> helps reviewers see what is going on.  Anyho, review TODO item: please ensure
> all tests are marked [ NeedsRebasleine ].

It can also ensure that the bots generate expected image, and that's how I found
that
bots generate slightly different image for date-suggestion-picker.

https://codereview.chromium.org/1571833002/diff/100001/content/shell/renderer...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/1571833002/diff/100001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:774: float scale =
render_view()->GetDeviceScaleFactorForTest();
On 2016/01/09 03:23:50, noel gordon wrote:
> On 2016/01/08 22:27:56, oshima wrote:
> > FYI: I added new method to get scale factor because because
> > WebView::deviceScaleFactor() will soon be deleted.
> > (https://codereview.chromium.org/1572703002/)
> 
> Add FIXME/TODO.

This code won't change.

https://codereview.chromium.org/1571833002/diff/120001/components/test_runner...
File components/test_runner/test_runner.cc (right):

https://codereview.chromium.org/1571833002/diff/120001/components/test_runner...
components/test_runner/test_runner.cc:1707: base::CommandLine* command_line =
base::CommandLine::ForCurrentProcess();
On 2016/01/09 03:23:51, noel gordon wrote:
> Define a static TestRuner::deviceScaleFactorForTest routine and put this code
in
> it.

I defined a utility function in anonymous namespace.

[tkent, 2016-01-11 23:55:53]

C++ code change looks good.

https://codereview.chromium.org/1571833002/diff/140001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1571833002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:227: crbug.com/495750 [ Win Mac
] virtual/scalefactor200/fast/hidpi/static [ NeedsRebaseline ]
Why only Win and Mac?

https://codereview.chromium.org/1571833002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:230: crbug.com/495750 [ Mac ]
virtual/scalefactor200withzoom/fast/hidpi/static [ Skip ]
Why is this skipped on Mac?

[oshima, 2016-01-12 00:12:22]

https://codereview.chromium.org/1571833002/diff/140001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1571833002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:227: crbug.com/495750 [ Win Mac
] virtual/scalefactor200/fast/hidpi/static [ NeedsRebaseline ]
On 2016/01/11 23:55:53, tkent (slow) wrote:
> Why only Win and Mac?

I added images for linux in this CL. Let me know if I should remove this and
regenerate images on all platforms.

https://codereview.chromium.org/1571833002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:230: crbug.com/495750 [ Mac ]
virtual/scalefactor200withzoom/fast/hidpi/static [ Skip ]
On 2016/01/11 23:55:53, tkent (slow) wrote:
> Why is this skipped on Mac?

use-zoom-for-dsf isn't ready on mac yet.

[tkent, 2016-01-12 00:16:23]

https://codereview.chromium.org/1571833002/diff/140001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1571833002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:227: crbug.com/495750 [ Win Mac
] virtual/scalefactor200/fast/hidpi/static [ NeedsRebaseline ]
On 2016/01/12 at 00:12:22, oshima wrote:
> On 2016/01/11 23:55:53, tkent (slow) wrote:
> > Why only Win and Mac?
> 
> I added images for linux in this CL. Let me know if I should remove this and
regenerate images on all platforms.

I recommend to do rebaseline for all platforms even if the CL contains pixel
results because
 - Bots might have configuration different from your local machine.
 - We have Android bots too.

https://codereview.chromium.org/1571833002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:230: crbug.com/495750 [ Mac ]
virtual/scalefactor200withzoom/fast/hidpi/static [ Skip ]
On 2016/01/12 at 00:12:22, oshima wrote:
> On 2016/01/11 23:55:53, tkent (slow) wrote:
> > Why is this skipped on Mac?
> 
> use-zoom-for-dsf isn't ready on mac yet.

I see.

[Noel Gordon, 2016-01-12 00:17:09]

On 2016/01/11 18:52:12, oshima wrote:
> PTAL
> 
> >
>
third_party/WebKit/LayoutTests/virtual/scalefactor150/fast/hidpi/static/README.txt
> >
>
third_party/WebKit/LayoutTests/virtual/scalefactor200/fast/hidpi/static/README.txt
> 
> They're not empty. For some reason, git cl upload treat them as binary file,
> probably
> because it misunderstands that they're rename of binary files. 
> (https://codereview.chromium.org/download/issue1571833002_140001_150052.diff)
> 
> 
> "git show" displays the text diff

IC.
 
> I tried adjusting similarity but no luck. Any advice?

No real advice.  I've had no success adjusting similarity either :/

>
https://codereview.chromium.org/1571833002/diff/100001/content/shell/renderer...
> content/shell/renderer/layout_test/blink_test_runner.cc:774: float scale =
> render_view()->GetDeviceScaleFactorForTest();
> On 2016/01/09 03:23:50, noel gordon wrote:
> > On 2016/01/08 22:27:56, oshima wrote:
> > > FYI: I added new method to get scale factor because because
> > > WebView::deviceScaleFactor() will soon be deleted.
> > > (https://codereview.chromium.org/1572703002/)
> > 
> > Add FIXME/TODO.
> 
> This code won't change.

Right, I misunderstood your FYI.  Nevermind.
 
>
https://codereview.chromium.org/1571833002/diff/120001/components/test_runner...
> components/test_runner/test_runner.cc:1707: base::CommandLine* command_line =
> base::CommandLine::ForCurrentProcess();
> On 2016/01/09 03:23:51, noel gordon wrote:
> > Define a static TestRuner::deviceScaleFactorForTest routine and put this
code
> in
> > it.
> 
> I defined a utility function in anonymous namespace.

Seems fine. LGTM.

[oshima, 2016-01-12 01:39:43]

https://codereview.chromium.org/1571833002/diff/140001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1571833002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:227: crbug.com/495750 [ Win Mac
] virtual/scalefactor200/fast/hidpi/static [ NeedsRebaseline ]
On 2016/01/12 00:16:22, tkent (slow) wrote:
> On 2016/01/12 at 00:12:22, oshima wrote:
> > On 2016/01/11 23:55:53, tkent (slow) wrote:
> > > Why only Win and Mac?
> > 
> > I added images for linux in this CL. Let me know if I should remove this and
> regenerate images on all platforms.
> 
> I recommend to do rebaseline for all platforms even if the CL contains pixel
> results because
>  - Bots might have configuration different from your local machine.
>  - We have Android bots too.

done

[Noel Gordon, 2016-01-12 02:12:07]

On 2016/01/12 01:39:43, oshima wrote:
>
https://codereview.chromium.org/1571833002/diff/140001/third_party/WebKit/Lay...
> File third_party/WebKit/LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/1571833002/diff/140001/third_party/WebKit/Lay...
> third_party/WebKit/LayoutTests/TestExpectations:227: crbug.com/495750 [ Win
Mac
> ] virtual/scalefactor200/fast/hidpi/static [ NeedsRebaseline ]
> On 2016/01/12 00:16:22, tkent (slow) wrote:
> > On 2016/01/12 at 00:12:22, oshima wrote:
> > > On 2016/01/11 23:55:53, tkent (slow) wrote:
> > > > Why only Win and Mac?
> > > 
> > > I added images for linux in this CL. Let me know if I should remove this
and
> > regenerate images on all platforms.
> > 
> > I recommend to do rebaseline for all platforms even if the CL contains pixel
> > results because
> >  - Bots might have configuration different from your local machine.
> >  - We have Android bots too.

Concur.

> done

You'll need approval from a src/components OWNER by the looks.

[oshima, 2016-01-12 02:40:22]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-12 02:40:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571833002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571833002/160001

[tkent, 2016-01-12 03:58:47]

third_party/WebKit and components/test_runner LGTM.

[commit-bot: I haz the power, 2016-01-12 03:59:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 03:59:49]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-01-12 18:15:20]

oshima@chromium.org changed reviewers:
+ sadrul@chromium.org

[oshima, 2016-01-12 18:15:20]

pfeldman@ -> content/ owner
sadrul@ -> html_viewer

[pfeldman, 2016-01-12 18:46:18]

content lgtm

[sadrul, 2016-01-12 19:08:26]

lgtm

[oshima, 2016-01-12 19:21:47]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-01-12 19:21:47]

The patchset sent to the CQ was uploaded after l-g-t-m from noel@chromium.org
Link to the patchset: https://codereview.chromium.org/1571833002/#ps160001
(title: " ")

[commit-bot: I haz the power, 2016-01-12 19:22:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571833002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571833002/160001

[commit-bot: I haz the power, 2016-01-12 19:40:24]

Description was changed from

==========
Add popup layout tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously
* data-suggestion-picker test is temporarily marked as failure as
  bots generate slightly different images. I'll investigate it in a separate CL.
* moved and enabled popup tests in fast/hidpi/static
* Added VirtualTestSuite for dsf=2, dsf=1.5 and dsf=2 with zooming option.

BUG=567837
==========

to

==========
Add popup layout tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously
* data-suggestion-picker test is temporarily marked as failure as
  bots generate slightly different images. I'll investigate it in a separate CL.
* moved and enabled popup tests in fast/hidpi/static
* Added VirtualTestSuite for dsf=2, dsf=1.5 and dsf=2 with zooming option.

BUG=567837
==========

[commit-bot: I haz the power, 2016-01-12 19:40:25]

Committed patchset #5 (id:160001)

[commit-bot: I haz the power, 2016-01-12 19:41:55]

Description was changed from

==========
Add popup layout tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously
* data-suggestion-picker test is temporarily marked as failure as
  bots generate slightly different images. I'll investigate it in a separate CL.
* moved and enabled popup tests in fast/hidpi/static
* Added VirtualTestSuite for dsf=2, dsf=1.5 and dsf=2 with zooming option.

BUG=567837
==========

to

==========
Add popup layout tests with device scale factor

This also contains following fix in layout test to enable these tests.
* allow --force-device-scale-factor in LayoutTest
* scale popup position when generating result image.
* fix the backing size in RenderWidget::SetWindowRectSynchronously
* data-suggestion-picker test is temporarily marked as failure as
  bots generate slightly different images. I'll investigate it in a separate CL.
* moved and enabled popup tests in fast/hidpi/static
* Added VirtualTestSuite for dsf=2, dsf=1.5 and dsf=2 with zooming option.

BUG=567837

Committed: https://crrev.com/c059194cf382b17fc5ef02b688b5ac7013f855b3
Cr-Commit-Position: refs/heads/master@{#368951}
==========

[commit-bot: I haz the power, 2016-01-12 19:41:57]

Patchset 5 (id:??) landed as
https://crrev.com/c059194cf382b17fc5ef02b688b5ac7013f855b3
Cr-Commit-Position: refs/heads/master@{#368951}