Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6741)

Unified Diff: chrome/browser/permissions/permission_uma_util.h

Issue 2123653006: Rename PermissionBubbleRequest to PermissionRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_manager_rename
Patch Set: PermissionBubbleType -> PermissionRequestType Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.h
diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h
index f16361737f09855b8c60492354361cddbffb109f..2101cc321e6dff43c78702ae340865dd4738b682 100644
--- a/chrome/browser/permissions/permission_uma_util.h
+++ b/chrome/browser/permissions/permission_uma_util.h
@@ -17,7 +17,7 @@ namespace content {
enum class PermissionType;
} // namespace content
-class PermissionBubbleRequest;
+class PermissionRequest;
// Enum for UMA purposes, make sure you update histograms.xml if you add new
// permission actions. Never delete or reorder an entry; only add new entries
@@ -71,7 +71,7 @@ class PermissionUmaUtil {
// granted+denied+dismissed+ignored is not equal to requested), so it is
// unclear from those metrics alone how many prompts are seen by users.
static void PermissionPromptShown(
- const std::vector<PermissionBubbleRequest*>& requests);
+ const std::vector<PermissionRequest*>& requests);
// The following two functions can be combined with the PermissionPromptShown
// metrics to calculate accept, deny and ignore rates.
@@ -79,11 +79,11 @@ class PermissionUmaUtil {
// always be called, with |accept_states| containing whether each request was
// accepted or denied.
static void PermissionPromptAccepted(
- const std::vector<PermissionBubbleRequest*>& requests,
+ const std::vector<PermissionRequest*>& requests,
const std::vector<bool>& accept_states);
static void PermissionPromptDenied(
- const std::vector<PermissionBubbleRequest*>& requests);
+ const std::vector<PermissionRequest*>& requests);
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUmaUtil);

Powered by Google App Engine
This is Rietveld 408576698