Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4693)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2123653006: Rename PermissionBubbleRequest to PermissionRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_manager_rename
Patch Set: PermissionBubbleType -> PermissionRequestType Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index efbdf5f04b6c65ff92efbb88a5fa6d95f2c44fb1..74af2e87992cfaa31374658325452c41f6a65c87 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -10,9 +10,16 @@
#include "base/strings/stringprintf.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/permissions/permission_manager.h"
+#include "chrome/browser/permissions/permission_request.h"
#include "chrome/browser/permissions/permission_util.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/website_settings/permission_bubble_request.h"
+#include "chrome/browser/safe_browsing/safe_browsing_service.h"
+#include "chrome/browser/safe_browsing/ui_manager.h"
+#include "chrome/browser/sync/profile_sync_service_factory.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
+#include "components/browser_sync/browser/profile_sync_service.h"
+#include "components/prefs/pref_service.h"
#include "components/rappor/rappor_service.h"
#include "components/rappor/rappor_utils.h"
#include "content/public/browser/permission_type.h"
@@ -36,7 +43,7 @@
UMA_HISTOGRAM_ENUMERATION( \
metric_name, \
static_cast<base::HistogramBase::Sample>(permission_bubble_type), \
- static_cast<base::HistogramBase::Sample>(PermissionBubbleType::NUM))
+ static_cast<base::HistogramBase::Sample>(PermissionRequestType::NUM))
using content::PermissionType;
@@ -312,12 +319,13 @@ void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
}
void PermissionUmaUtil::PermissionPromptShown(
- const std::vector<PermissionBubbleRequest*>& requests) {
+ const std::vector<PermissionRequest*>& requests) {
DCHECK(!requests.empty());
- PermissionBubbleType permission_prompt_type = PermissionBubbleType::MULTIPLE;
+ PermissionRequestType permission_prompt_type =
+ PermissionRequestType::MULTIPLE;
if (requests.size() == 1)
- permission_prompt_type = requests[0]->GetPermissionBubbleType();
+ permission_prompt_type = requests[0]->GetPermissionRequestType();
PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptShown, permission_prompt_type);
UMA_HISTOGRAM_ENUMERATION(
@@ -328,31 +336,31 @@ void PermissionUmaUtil::PermissionPromptShown(
if (requests.size() > 1) {
for (const auto* request : requests) {
PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptMergedBubbleTypes,
- request->GetPermissionBubbleType());
+ request->GetPermissionRequestType());
}
}
}
void PermissionUmaUtil::PermissionPromptAccepted(
- const std::vector<PermissionBubbleRequest*>& requests,
+ const std::vector<PermissionRequest*>& requests,
const std::vector<bool>& accept_states) {
DCHECK(!requests.empty());
DCHECK(requests.size() == accept_states.size());
bool all_accepted = accept_states[0];
- PermissionBubbleType permission_prompt_type =
- requests[0]->GetPermissionBubbleType();
+ PermissionRequestType permission_prompt_type =
+ requests[0]->GetPermissionRequestType();
if (requests.size() > 1) {
- permission_prompt_type = PermissionBubbleType::MULTIPLE;
+ permission_prompt_type = PermissionRequestType::MULTIPLE;
for (size_t i = 0; i < requests.size(); ++i) {
const auto* request = requests[i];
if (accept_states[i]) {
PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptMergedBubbleAccepted,
- request->GetPermissionBubbleType());
+ request->GetPermissionRequestType());
} else {
all_accepted = false;
PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptMergedBubbleDenied,
- request->GetPermissionBubbleType());
+ request->GetPermissionRequestType());
}
}
}
@@ -367,10 +375,10 @@ void PermissionUmaUtil::PermissionPromptAccepted(
}
void PermissionUmaUtil::PermissionPromptDenied(
- const std::vector<PermissionBubbleRequest*>& requests) {
+ const std::vector<PermissionRequest*>& requests) {
DCHECK(!requests.empty());
DCHECK(requests.size() == 1);
PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptDenied,
- requests[0]->GetPermissionBubbleType());
+ requests[0]->GetPermissionRequestType());
}

Powered by Google App Engine
This is Rietveld 408576698