Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: chrome/browser/permissions/permission_uma_util.h

Issue 2123653006: Rename PermissionBubbleRequest to PermissionRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_manager_rename
Patch Set: PermissionBubbleType -> PermissionRequestType Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_ 5 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_
6 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_ 6 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 12
13 class GURL; 13 class GURL;
14 class Profile; 14 class Profile;
15 15
16 namespace content { 16 namespace content {
17 enum class PermissionType; 17 enum class PermissionType;
18 } // namespace content 18 } // namespace content
19 19
20 class PermissionBubbleRequest; 20 class PermissionRequest;
21 21
22 // Enum for UMA purposes, make sure you update histograms.xml if you add new 22 // Enum for UMA purposes, make sure you update histograms.xml if you add new
23 // permission actions. Never delete or reorder an entry; only add new entries 23 // permission actions. Never delete or reorder an entry; only add new entries
24 // immediately before PERMISSION_NUM 24 // immediately before PERMISSION_NUM
25 enum PermissionAction { 25 enum PermissionAction {
26 GRANTED = 0, 26 GRANTED = 0,
27 DENIED = 1, 27 DENIED = 1,
28 DISMISSED = 2, 28 DISMISSED = 2,
29 IGNORED = 3, 29 IGNORED = 3,
30 REVOKED = 4, 30 REVOKED = 4,
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 // UMA specifically for when permission prompts are shown. This should be 64 // UMA specifically for when permission prompts are shown. This should be
65 // roughly equivalent to the metrics above, however it is 65 // roughly equivalent to the metrics above, however it is
66 // useful to have separate UMA to a few reasons: 66 // useful to have separate UMA to a few reasons:
67 // - to account for, and get data on coalesced permission bubbles 67 // - to account for, and get data on coalesced permission bubbles
68 // - there are other types of permissions prompts (e.g. download limiting) 68 // - there are other types of permissions prompts (e.g. download limiting)
69 // which don't go through PermissionContext 69 // which don't go through PermissionContext
70 // - the above metrics don't always add up (e.g. sum of 70 // - the above metrics don't always add up (e.g. sum of
71 // granted+denied+dismissed+ignored is not equal to requested), so it is 71 // granted+denied+dismissed+ignored is not equal to requested), so it is
72 // unclear from those metrics alone how many prompts are seen by users. 72 // unclear from those metrics alone how many prompts are seen by users.
73 static void PermissionPromptShown( 73 static void PermissionPromptShown(
74 const std::vector<PermissionBubbleRequest*>& requests); 74 const std::vector<PermissionRequest*>& requests);
75 75
76 // The following two functions can be combined with the PermissionPromptShown 76 // The following two functions can be combined with the PermissionPromptShown
77 // metrics to calculate accept, deny and ignore rates. 77 // metrics to calculate accept, deny and ignore rates.
78 // Note that for coalesced permission bubbles, PermissionPromptAccepted will 78 // Note that for coalesced permission bubbles, PermissionPromptAccepted will
79 // always be called, with |accept_states| containing whether each request was 79 // always be called, with |accept_states| containing whether each request was
80 // accepted or denied. 80 // accepted or denied.
81 static void PermissionPromptAccepted( 81 static void PermissionPromptAccepted(
82 const std::vector<PermissionBubbleRequest*>& requests, 82 const std::vector<PermissionRequest*>& requests,
83 const std::vector<bool>& accept_states); 83 const std::vector<bool>& accept_states);
84 84
85 static void PermissionPromptDenied( 85 static void PermissionPromptDenied(
86 const std::vector<PermissionBubbleRequest*>& requests); 86 const std::vector<PermissionRequest*>& requests);
87 87
88 private: 88 private:
89 DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUmaUtil); 89 DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUmaUtil);
90 }; 90 };
91 91
92 #endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_ 92 #endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698