Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2122493002: Update WebGL2 conformance tests (Closed)

Created:
4 years, 5 months ago by Zhenyao Mo
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WebGL2 conformance tests BUG= TEST=GPU bots TBR=kbr@chromium.org NOTRY=true NOTREECHECKS=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/ab3469f179cdb8a466fdf771a92480178b517024 Cr-Commit-Position: refs/heads/master@{#403618}

Patch Set 1 #

Patch Set 2 : Update WebGL2 conformance tests #

Patch Set 3 : Update WebGL2 conformance tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -19 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 9 chunks +84 lines, -19 lines 2 comments Download

Dependent Patchsets:

Issue 2119093002 Patch 1
Issue 2119093002 Patch 20001
Issue 2121683002 Patch 1
Issue 2121683002 Patch 20001

Messages

Total messages: 15 (9 generated)
Zhenyao Mo
https://codereview.chromium.org/2122493002/diff/40001/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2122493002/diff/40001/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py#newcode174 content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:174: self.Flaky('deqp/*', ['win', ('amd', 0x6779)], bug=491419) This has to stay ...
4 years, 5 months ago (2016-07-03 23:36:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122493002/40001
4 years, 5 months ago (2016-07-03 23:36:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122493002/40001
4 years, 5 months ago (2016-07-03 23:56:12 UTC) #8
commit-bot: I haz the power
Failed to apply the patch.
4 years, 5 months ago (2016-07-04 00:02:21 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ab3469f179cdb8a466fdf771a92480178b517024 Cr-Commit-Position: refs/heads/master@{#403618}
4 years, 5 months ago (2016-07-04 00:04:13 UTC) #12
Ken Russell (switch to Gerrit)
4 years, 5 months ago (2016-07-06 19:47:39 UTC) #13
Message was sent while issue was closed. 
https://codereview.chromium.org/2122493002/diff/40001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right):

https://codereview.chromium.org/2122493002/diff/40001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:174:
self.Flaky('deqp/*', ['win', ('amd', 0x6779)], bug=491419)
On 2016/07/03 23:36:15, Zhenyao Mo wrote:
> This has to stay in the last, otherwise the above textureshadow tests will
have
> expectation of "flaky" instead of "fail", and turning bot red.

OK. Hopefully we can fix the textureshadow failures soon so that there will only
be one wildcard suppression.

Powered by Google App Engine
This is Rietveld 408576698