third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js - Issue 2122353002: [DevTools] Make resource tree model optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js

Issue 2122353002: [DevTools] Make resource tree model optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js ('K') | « third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js » ('j') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js

index e69fae53dfc53cca11434bcf996cdf5c704522af..a4ea50e05089663ac239e43b763beb34da7afb5f 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js

@@ -88,7 +88,7 @@ WebInspector.ElementsSidebarPane.prototype = {

if (target) {

this._cssModel = WebInspector.CSSModel.fromTarget(target);

domModel = WebInspector.DOMModel.fromTarget(target);

- resourceTreeModel = target.resourceTreeModel;

+ resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(target);

}

if (this._cssModel && domModel && resourceTreeModel) {

dgozman 2016/07/14 16:29:28 We should split "&& resourceTreeModel" out. This p

eostroukhov-old 2016/07/20 23:46:15 This code have been removed.