third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js - Issue 2122353002: [DevTools] Make resource tree model optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 2122353002: [DevTools] Make resource tree model optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js ('K') | « third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js » ('j') | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

index 396f912432d32a28468d4346972ca18cf324c59e..d42f276dcfbda2b6f858a9d5001e706908e59e27 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

@@ -654,7 +654,10 @@ WebInspector.ElementsTreeOutline.prototype = {

{

var listItem = anchor.enclosingNodeOrSelfWithNodeName("li");

var node = /** @type {!WebInspector.ElementsTreeElement} */ (listItem.treeElement).node();

- this._loadDimensionsForNode(node, WebInspector.DOMPresentationUtils.buildImagePreviewContents.bind(WebInspector.DOMPresentationUtils, node.target(), anchor.href, true, showPopover));

+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(node.target());

pfeldman 2016/07/13 23:55:57 ditto

eostroukhov-old 2016/07/20 23:46:15 Reverted.

+ if (!resourceTreeModel)

+ return;

+ this._loadDimensionsForNode(node, WebInspector.DOMPresentationUtils.buildImagePreviewContents.bind(WebInspector.DOMPresentationUtils, resourceTreeModel, anchor.href, true, showPopover));

/**

* @param {!Element=} contents