third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js - Issue 2122353002: [DevTools] Make resource tree model optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

Issue 2122353002: [DevTools] Make resource tree model optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('K') | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js » ('j') | third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

index d4ca4cc4a54dabe8eca764dec32beb5c98b2a0d9..fe67cc99f6b45abed0ae40ac51f992d8f861dc84 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

@@ -563,8 +563,9 @@ WebInspector.ElementsPanel.prototype = {

_showPopover: function(anchor, popover)

{

var node = this.selectedDOMNode();

- if (node)

- WebInspector.DOMPresentationUtils.buildImagePreviewContents(node.target(), anchor.href, true, showPopover);

+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(node.target());

pfeldman 2016/07/13 23:55:57 ditto

eostroukhov-old 2016/07/20 23:46:15 Reverted

+ if (node && resourceTreeModel)

+ WebInspector.DOMPresentationUtils.buildImagePreviewContents(resourceTreeModel, anchor.href, true, showPopover);

/**

* @param {!Element=} contents