components/nacl/common/nacl_host_messages.h - Issue 212103002: Check NaCl debug mask (not just flag) before choosing PNaCl debug URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/common/nacl_host_messages.h

Issue 212103002: Check NaCl debug mask (not just flag) before choosing PNaCl debug URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html ('K') | « components/nacl/browser/nacl_host_message_filter.cc ('k') | components/nacl/renderer/ppb_nacl_private_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/common/nacl_host_messages.h

diff --git a/components/nacl/common/nacl_host_messages.h b/components/nacl/common/nacl_host_messages.h

index 3a1e447b85ebcdbb22809cdc716fbda9587dc7ef..a7fff9ee03fe15f4ba95e784f993081926519693 100644

--- a/components/nacl/common/nacl_host_messages.h

+++ b/components/nacl/common/nacl_host_messages.h

@@ -106,3 +106,7 @@ IPC_SYNC_MESSAGE_CONTROL2_3(NaClHostMsg_OpenNaClExecutable,

IPC_SYNC_MESSAGE_CONTROL0_1(NaClHostMsg_NaClGetNumProcessors,

int /* Number of processors */)

Tom Sepez 2014/03/26 23:25:12 Nit: maybe a comment as all but this (and the one

jvoung (off chromium) 2014/03/27 20:41:24 Done.

+IPC_SYNC_MESSAGE_CONTROL1_1(NaClHostMsg_NaClDebugEnabledForURL,

+ GURL /* alleged URL of NMF file */,

+ bool /* should debug */)