Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4669)

Unified Diff: chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html

Issue 212103002: Check NaCl debug mask (not just flag) before choosing PNaCl debug URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/nacl/nacl_browsertest.cc » ('j') | components/nacl/common/nacl_host_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html
diff --git a/chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html b/chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html
index 7702afca9ccc67807a029d7a71ecbb319b9aea28..a24eb3eb80dcaa2cf024729282b7b3ebc2a9ec06 100644
--- a/chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html
+++ b/chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html
@@ -20,10 +20,14 @@ function create(nmf_url) {
embed.type = "application/x-pnacl";
embed.addEventListener("load", function(evt) {
load_util.shutdown("1 test passed.", true);
+ // Remove the embed so that the debugger will shut down.
+ embed.parentNode.removeChild(embed);
bradn 2014/03/27 16:57:14 FWIW I've observed that the debug stub ends up kee
}, true);
embed.addEventListener("error", function(evt) {
load_util.log("Load error: " + embed.lastError);
load_util.shutdown("1 test failed.", false);
+ // Remove the embed so that the debugger will shut down.
+ embed.parentNode.removeChild(embed);
}, true);
document.body.appendChild(embed);
}
« no previous file with comments | « no previous file | chrome/test/nacl/nacl_browsertest.cc » ('j') | components/nacl/common/nacl_host_messages.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698