components/nacl/common/nacl_host_messages.h - Issue 212103002: Check NaCl debug mask (not just flag) before choosing PNaCl debug URL.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/nacl/common/nacl_host_messages.h

Issue 212103002: Check NaCl debug mask (not just flag) before choosing PNaCl debug URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html ('K') | « components/nacl/browser/nacl_host_message_filter.cc ('k') | components/nacl/renderer/ppb_nacl_private_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included file, no traditional include guard.	5 // Multiply-included file, no traditional include guard.

6	6

7 #include <string>	7 #include <string>

8	8

9 #include "base/basictypes.h"	9 #include "base/basictypes.h"

10 #include "base/process/process.h"	10 #include "base/process/process.h"

(...skipping 88 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
99 // open a NaCl executable file from an installed application directory.	99 // open a NaCl executable file from an installed application directory.

100 IPC_SYNC_MESSAGE_CONTROL2_3(NaClHostMsg_OpenNaClExecutable,	100 IPC_SYNC_MESSAGE_CONTROL2_3(NaClHostMsg_OpenNaClExecutable,

101 int /* render_view_id */,	101 int /* render_view_id */,

102 GURL /* URL of NaCl executable file */,	102 GURL /* URL of NaCl executable file */,

103 IPC::PlatformFileForTransit /* output file */,	103 IPC::PlatformFileForTransit /* output file */,

104 uint64 /* file_token_lo */,	104 uint64 /* file_token_lo */,

105 uint64 /* file_token_hi */)	105 uint64 /* file_token_hi */)

106	106

107 IPC_SYNC_MESSAGE_CONTROL0_1(NaClHostMsg_NaClGetNumProcessors,	107 IPC_SYNC_MESSAGE_CONTROL0_1(NaClHostMsg_NaClGetNumProcessors,

108 int /* Number of processors */)	108 int /* Number of processors */)

	109
	Tom Sepez 2014/03/26 23:25:12 Nit: maybe a comment as all but this (and the one Nit: maybe a comment as all but this (and the one above it) have comments. jvoung (off chromium) 2014/03/27 20:41:24 Done. Show quoted text On 2014/03/26 23:25:12, Tom Sepez wrote: > Nit: maybe a comment as all but this (and the one above it) have comments. Done.
	110 IPC_SYNC_MESSAGE_CONTROL1_1(NaClHostMsg_NaClDebugEnabledForURL,

	111 GURL /* alleged URL of NMF file */,

	112 bool /* should debug */)

OLD	NEW