Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Side by Side Diff: components/cronet/url_request_context_config_unittest.cc

Issue 2120703003: QUIC - Race Cert Verification with host resolution if certs are (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/cronet/url_request_context_config.cc ('k') | net/http/http_network_session.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/cronet/url_request_context_config.h" 5 #include "components/cronet/url_request_context_config.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "net/cert/cert_verifier.h" 9 #include "net/cert/cert_verifier.h"
10 #include "net/http/http_network_session.h" 10 #include "net/http/http_network_session.h"
(...skipping 29 matching lines...) Expand all
40 // JSON encoded experimental options. 40 // JSON encoded experimental options.
41 "{\"QUIC\":{\"max_server_configs_stored_in_properties\":2," 41 "{\"QUIC\":{\"max_server_configs_stored_in_properties\":2,"
42 "\"delay_tcp_race\":true," 42 "\"delay_tcp_race\":true,"
43 "\"max_number_of_lossy_connections\":10," 43 "\"max_number_of_lossy_connections\":10,"
44 "\"prefer_aes\":true," 44 "\"prefer_aes\":true,"
45 "\"user_agent_id\":\"Custom QUIC UAID\"," 45 "\"user_agent_id\":\"Custom QUIC UAID\","
46 "\"packet_loss_threshold\":0.5," 46 "\"packet_loss_threshold\":0.5,"
47 "\"idle_connection_timeout_seconds\":300," 47 "\"idle_connection_timeout_seconds\":300,"
48 "\"close_sessions_on_ip_change\":true," 48 "\"close_sessions_on_ip_change\":true,"
49 "\"connection_options\":\"TIME,TBBR,REJ\"}," 49 "\"connection_options\":\"TIME,TBBR,REJ\"},"
50 "\"race_cert_verification\":true,"
mef 2016/07/08 13:23:50 I think test below fails because this line is NOT
ramant (doing other things) 2016/07/08 23:13:49 Done.
50 "\"AsyncDNS\":{\"enable\":true}}", 51 "\"AsyncDNS\":{\"enable\":true}}",
51 // Data reduction proxy key. 52 // Data reduction proxy key.
52 "", 53 "",
53 // Data reduction proxy. 54 // Data reduction proxy.
54 "", 55 "",
55 // Fallback data reduction proxy. 56 // Fallback data reduction proxy.
56 "", 57 "",
57 // Data reduction proxy secure proxy check URL. 58 // Data reduction proxy secure proxy check URL.
58 "", 59 "",
59 // MockCertVerifier to use for testing purposes. 60 // MockCertVerifier to use for testing purposes.
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 // Check max_number_of_lossy_connections and packet_loss_threshold. 95 // Check max_number_of_lossy_connections and packet_loss_threshold.
95 EXPECT_EQ(10, params->quic_max_number_of_lossy_connections); 96 EXPECT_EQ(10, params->quic_max_number_of_lossy_connections);
96 EXPECT_FLOAT_EQ(0.5f, params->quic_packet_loss_threshold); 97 EXPECT_FLOAT_EQ(0.5f, params->quic_packet_loss_threshold);
97 98
98 // Check idle_connection_timeout_seconds. 99 // Check idle_connection_timeout_seconds.
99 EXPECT_EQ(300, params->quic_idle_connection_timeout_seconds); 100 EXPECT_EQ(300, params->quic_idle_connection_timeout_seconds);
100 101
101 EXPECT_TRUE(params->quic_close_sessions_on_ip_change); 102 EXPECT_TRUE(params->quic_close_sessions_on_ip_change);
102 EXPECT_FALSE(params->quic_migrate_sessions_on_network_change); 103 EXPECT_FALSE(params->quic_migrate_sessions_on_network_change);
103 104
105 // Check race_cert_verification.
106 EXPECT_TRUE(params->quic_race_cert_verification);
107
104 // Check AsyncDNS resolver is enabled. 108 // Check AsyncDNS resolver is enabled.
105 EXPECT_TRUE(context->host_resolver()->GetDnsConfigAsValue()); 109 EXPECT_TRUE(context->host_resolver()->GetDnsConfigAsValue());
106 } 110 }
107 111
108 TEST(URLRequestContextConfigTest, SetQuicConnectionMigrationOptions) { 112 TEST(URLRequestContextConfigTest, SetQuicConnectionMigrationOptions) {
109 URLRequestContextConfig config( 113 URLRequestContextConfig config(
110 // Enable QUIC. 114 // Enable QUIC.
111 true, 115 true,
112 // QUIC User Agent ID. 116 // QUIC User Agent ID.
113 "Default QUIC User Agent ID", 117 "Default QUIC User Agent ID",
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 std::unique_ptr<net::URLRequestContext> context(builder.Build()); 157 std::unique_ptr<net::URLRequestContext> context(builder.Build());
154 const net::HttpNetworkSession::Params* params = 158 const net::HttpNetworkSession::Params* params =
155 context->GetNetworkSessionParams(); 159 context->GetNetworkSessionParams();
156 160
157 EXPECT_FALSE(params->quic_close_sessions_on_ip_change); 161 EXPECT_FALSE(params->quic_close_sessions_on_ip_change);
158 EXPECT_TRUE(params->quic_migrate_sessions_on_network_change); 162 EXPECT_TRUE(params->quic_migrate_sessions_on_network_change);
159 EXPECT_TRUE(params->quic_migrate_sessions_early); 163 EXPECT_TRUE(params->quic_migrate_sessions_early);
160 } 164 }
161 165
162 } // namespace cronet 166 } // namespace cronet
OLDNEW
« no previous file with comments | « components/cronet/url_request_context_config.cc ('k') | net/http/http_network_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698