Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 212063004: Remove Ununsed Input Variable from ScrollAnimator NotifyPosChange (Closed)

Created:
6 years, 9 months ago by weiliangc
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers, danakj, Ian Vollick, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove Ununsed Input Variable from ScrollAnimator NotifyPosChange NotifyPositionChange pass on stored m_currentPos, and didn't use its input variable. Removing its input variable from signature to reflect this. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170499

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -24 lines) Patch
M Source/platform/mac/ScrollAnimatorMac.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/mac/ScrollAnimatorMac.mm View 3 chunks +4 lines, -8 lines 0 comments Download
M Source/platform/scroll/ScrollAnimator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/ScrollAnimator.cpp View 2 chunks +7 lines, -10 lines 0 comments Download
M Source/platform/scroll/ScrollAnimatorNone.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
weiliangc
6 years, 9 months ago (2014-03-26 18:52:45 UTC) #1
weiliangc
Changed to more relevant reviewer.
6 years, 9 months ago (2014-03-27 22:05:57 UTC) #2
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-27 23:05:34 UTC) #3
weiliangc
The CQ bit was checked by weiliangc@chromium.org
6 years, 9 months ago (2014-03-28 13:49:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/212063004/1
6 years, 9 months ago (2014-03-28 13:49:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 14:13:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-28 14:13:55 UTC) #7
weiliangc
The CQ bit was checked by weiliangc@chromium.org
6 years, 8 months ago (2014-03-31 21:53:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/212063004/50001
6 years, 8 months ago (2014-03-31 21:54:00 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 22:20:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-03-31 22:20:23 UTC) #11
weiliangc
The CQ bit was checked by weiliangc@chromium.org
6 years, 8 months ago (2014-04-01 00:42:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/212063004/50001
6 years, 8 months ago (2014-04-01 00:42:48 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 01:28:03 UTC) #14
Message was sent while issue was closed.
Change committed as 170499

Powered by Google App Engine
This is Rietveld 408576698