Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: Source/platform/scroll/ScrollAnimatorNone.cpp

Issue 212063004: Remove Ununsed Input Variable from ScrollAnimator NotifyPosChange (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/scroll/ScrollAnimator.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/scroll/ScrollAnimatorNone.cpp
diff --git a/Source/platform/scroll/ScrollAnimatorNone.cpp b/Source/platform/scroll/ScrollAnimatorNone.cpp
index 14f9e425ae127590df5261ac9e5f67208376f46d..4a24201241b5a35b37f3c3de5060472d319feafb 100644
--- a/Source/platform/scroll/ScrollAnimatorNone.cpp
+++ b/Source/platform/scroll/ScrollAnimatorNone.cpp
@@ -437,17 +437,17 @@ void ScrollAnimatorNone::scrollToOffsetWithoutAnimation(const FloatPoint& offset
{
stopAnimationTimerIfNeeded();
- FloatSize delta = FloatSize(offset.x() - *m_horizontalData.m_currentPosition, offset.y() - *m_verticalData.m_currentPosition);
-
m_horizontalData.reset();
*m_horizontalData.m_currentPosition = offset.x();
m_horizontalData.m_desiredPosition = offset.x();
+ m_currentPosX = offset.x();
m_verticalData.reset();
*m_verticalData.m_currentPosition = offset.y();
m_verticalData.m_desiredPosition = offset.y();
+ m_currentPosY = offset.y();
- notifyPositionChanged(delta);
+ notifyPositionChanged();
}
void ScrollAnimatorNone::cancelAnimations()
@@ -500,7 +500,7 @@ void ScrollAnimatorNone::animationTimerFired()
m_animationActive = false;
TRACE_EVENT0("webkit", "ScrollAnimatorNone::notifyPositionChanged");
- notifyPositionChanged(FloatSize());
+ notifyPositionChanged();
if (!continueAnimation)
animationDidFinish();
« no previous file with comments | « Source/platform/scroll/ScrollAnimator.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698