Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2659)

Unified Diff: Source/platform/mac/ScrollAnimatorMac.mm

Issue 212063004: Remove Ununsed Input Variable from ScrollAnimator NotifyPosChange (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/mac/ScrollAnimatorMac.h ('k') | Source/platform/scroll/ScrollAnimator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/mac/ScrollAnimatorMac.mm
diff --git a/Source/platform/mac/ScrollAnimatorMac.mm b/Source/platform/mac/ScrollAnimatorMac.mm
index f0bde43a649baabcea1125b9f43d88d34a866794..bb2668628c8226cf7034d093c4efe2b1e8bd18dd 100644
--- a/Source/platform/mac/ScrollAnimatorMac.mm
+++ b/Source/platform/mac/ScrollAnimatorMac.mm
@@ -705,7 +705,8 @@ void ScrollAnimatorMac::immediateScrollTo(const FloatPoint& newPosition)
m_currentPosX = adjustedPosition.x();
m_currentPosY = adjustedPosition.y();
- notifyPositionChanged(delta);
+ notifyContentAreaScrolled(delta);
+ notifyPositionChanged();
}
bool ScrollAnimatorMac::isRubberBandInProgress() const
@@ -723,12 +724,6 @@ void ScrollAnimatorMac::immediateScrollToPointForScrollAnimation(const FloatPoin
immediateScrollTo(newPosition);
}
-void ScrollAnimatorMac::notifyPositionChanged(const FloatSize& delta)
-{
- notifyContentAreaScrolled(delta);
- ScrollAnimator::notifyPositionChanged(delta);
-}
-
void ScrollAnimatorMac::contentAreaWillPaint() const
{
if (!scrollableArea()->scrollbarsCanBeActive())
@@ -1141,7 +1136,8 @@ void ScrollAnimatorMac::immediateScrollBy(const FloatSize& delta)
m_currentPosX = newPos.x();
m_currentPosY = newPos.y();
- notifyPositionChanged(adjustedDelta);
+ notifyContentAreaScrolled(adjustedDelta);
+ notifyPositionChanged();
}
void ScrollAnimatorMac::startSnapRubberbandTimer()
« no previous file with comments | « Source/platform/mac/ScrollAnimatorMac.h ('k') | Source/platform/scroll/ScrollAnimator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698