Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2119633002: Remove support for pretenuring as it is not fully implemented and is currently turned on for a very… (Closed)

Created:
4 years, 5 months ago by siva
Modified:
4 years, 5 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove support for pretenuring as it is not fully implemented and is currently turned on for a very specific case (double to string for one byte strings). R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/de5a1c8dac234de495559113aec56f593cfb317d

Patch Set 1 #

Patch Set 2 : Address self review changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -115 lines) Patch
M runtime/lib/double.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/lib/string.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/flag_list.h View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/heap.h View 1 7 chunks +0 lines, -11 lines 0 comments Download
M runtime/vm/heap.cc View 1 6 chunks +3 lines, -53 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 5 months ago (2016-06-30 20:53:44 UTC) #2
Florian Schneider
LGTM!
4 years, 5 months ago (2016-06-30 20:57:31 UTC) #3
siva
4 years, 5 months ago (2016-07-01 19:59:25 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
de5a1c8dac234de495559113aec56f593cfb317d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698