runtime/vm/intrinsifier_mips.cc - Issue 2119633002: Remove support for pretenuring as it is not fully implemented and is currently turned on for a very…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_mips.cc

Issue 2119633002: Remove support for pretenuring as it is not fully implemented and is currently turned on for a very… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address self review changes. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_mips.cc

diff --git a/runtime/vm/intrinsifier_mips.cc b/runtime/vm/intrinsifier_mips.cc

index d8da47064948b5ea240b6e73cdeab228e20d7610..937051eb38e03a5465ce98df3bdea94dc7487abc 100644

--- a/runtime/vm/intrinsifier_mips.cc

+++ b/runtime/vm/intrinsifier_mips.cc

@@ -177,7 +177,7 @@ void Intrinsifier::GrowableArray_add(Assembler* assembler) {

__ AddImmediate(T2, fixed_size); \

__ LoadImmediate(TMP, -kObjectAlignment); \

__ and_(T2, T2, TMP); \

- Heap::Space space = Heap::SpaceForAllocation(cid); \

+ Heap::Space space = Heap::kNew; \

__ lw(T3, Address(THR, Thread::heap_offset())); \

__ lw(V0, Address(T3, Heap::TopOffset(space))); \

@@ -1951,7 +1951,7 @@ static void TryAllocateOnebyteString(Assembler* assembler,

__ and_(length_reg, length_reg, TMP);

const intptr_t cid = kOneByteStringCid;

- Heap::Space space = Heap::SpaceForAllocation(cid);

+ Heap::Space space = Heap::kNew;

__ lw(T3, Address(THR, Thread::heap_offset()));

__ lw(V0, Address(T3, Heap::TopOffset(space)));

« no previous file with comments | « runtime/vm/intrinsifier_ia32.cc ('k') | runtime/vm/intrinsifier_x64.cc » ('j') | no next file with comments »