Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: runtime/vm/heap.h

Issue 2119633002: Remove support for pretenuring as it is not fully implemented and is currently turned on for a very… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address self review changes. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flag_list.h ('k') | runtime/vm/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/heap.h
diff --git a/runtime/vm/heap.h b/runtime/vm/heap.h
index d13150ecdd30cd8667cf8a8ffee7f191b6a2caef..d5c16245dd59ff6519167c50ef3ce73133bb7816 100644
--- a/runtime/vm/heap.h
+++ b/runtime/vm/heap.h
@@ -31,8 +31,6 @@ class Heap {
kNew,
kOld,
kCode,
- // TODO(koda): Harmonize all old-space allocation and get rid of this.
- kPretenured,
};
enum WeakSelector {
@@ -81,8 +79,6 @@ class Heap {
return AllocateOld(size, HeapPage::kData);
case kCode:
return AllocateOld(size, HeapPage::kExecutable);
- case kPretenured:
- return AllocatePretenured(size);
default:
UNREACHABLE();
}
@@ -148,7 +144,6 @@ class Heap {
// Accessors for inlined allocation in generated code.
static intptr_t TopOffset(Space space);
static intptr_t EndOffset(Space space);
- static Space SpaceForAllocation(intptr_t class_id);
// Initialize the heap and register it with the isolate.
static void Init(Isolate* isolate,
@@ -260,8 +255,6 @@ class Heap {
intptr_t finalization_tasks() const { return finalization_tasks_; }
void set_finalization_tasks(intptr_t count) { finalization_tasks_ = count; }
- bool ShouldPretenure(intptr_t class_id) const;
-
void SetupExternalPage(void* pointer, uword size, bool is_executable) {
old_space_.SetupExternalPage(pointer, size, is_executable);
}
@@ -306,7 +299,6 @@ class Heap {
uword AllocateNew(intptr_t size);
uword AllocateOld(intptr_t size, HeapPage::PageType type);
- uword AllocatePretenured(intptr_t size);
// Visit all pointers. Caller must ensure concurrent sweeper is not running,
// and the visitor must not allocate.
@@ -331,7 +323,6 @@ class Heap {
void RecordAfterGC(Space space);
void PrintStats();
void UpdateClassHeapStatsBeforeGC(Heap::Space space);
- void UpdatePretenurePolicy();
void PrintStatsToTimeline(TimelineEventScope* event);
// Updates gc in progress flags.
@@ -371,8 +362,6 @@ class Heap {
bool gc_new_space_in_progress_;
bool gc_old_space_in_progress_;
- int pretenure_policy_;
-
friend class Become; // VisitObjectPointers
friend class ServiceEvent;
friend class PageSpace; // VerifyGC
« no previous file with comments | « runtime/vm/flag_list.h ('k') | runtime/vm/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698