Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: content/browser/devtools/protocol/browser_handler.cc

Issue 2119063002: Add commands to manage tabs and contexts to Browser Domain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes for Sami Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/browser_handler.cc
diff --git a/content/browser/devtools/protocol/browser_handler.cc b/content/browser/devtools/protocol/browser_handler.cc
index ac575f616ea2791c44ed11070dfbcea6cb68dd29..e8084f07898c711c5701721e67b1643e208adc4a 100644
--- a/content/browser/devtools/protocol/browser_handler.cc
+++ b/content/browser/devtools/protocol/browser_handler.cc
@@ -43,6 +43,39 @@ static std::string GetTypeString(DevToolsAgentHost* agent_host) {
}
}
+Response BrowserHandler::NewBrowserContext(std::string* out_contextId) {
+ // For layering reasons this neends to be handled by
dgozman 2016/07/06 18:33:30 typo: neends
alex clarke (OOO till 29th) 2016/07/06 20:25:06 Done.
+ // DevToolsManagerDelegate::HandleCommand.
+ return Response::ServerError("Not supported");
+}
+
+Response BrowserHandler::CloseBrowserContext(const std::string& contextId,
+ bool* out_success) {
+ // For layering reasons this neends to be handled by
+ // DevToolsManagerDelegate::HandleCommand.
+ return Response::ServerError("Not supported");
+}
+
+Response BrowserHandler::NewPage(const std::string& in_initialUrl,
+ const int* in_width,
+ const int* in_height,
+ const std::string* in_context,
+ std::string* out_targetId) {
+ // For layering reasons this neends to be handled by
+ // DevToolsManagerDelegate::HandleCommand.
+ return Response::ServerError("Not supported");
+}
+
+Response BrowserHandler::ClosePage(const std::string& targetId,
+ bool* out_success) {
+ scoped_refptr<DevToolsAgentHost> agent_host =
+ DevToolsAgentHost::GetForId(targetId);
+ if (!agent_host)
+ return Response::ServerError("No target with given id found");
+ *out_success = agent_host->Close();
+ return Response::OK();
+}
+
Response BrowserHandler::GetTargets(TargetInfos* infos) {
DevToolsAgentHost::List agents = DevToolsAgentHost::GetOrCreateAll();
for (DevToolsAgentHost::List::iterator it = agents.begin();

Powered by Google App Engine
This is Rietveld 408576698