Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2119063002: Add commands to manage tabs and contexts to Browser Domain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes for Sami Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/browser_protocol.json
diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json
index a27991a3a75b2ca4fa629da9c3575e835791833b..4f6e7bcf486c700e6931d5e8a10ce6c871c578b9 100644
--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json
+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json
@@ -4236,6 +4236,10 @@
"hidden": true,
"types": [
{
+ "id": "BrowserContextID",
+ "type": "string"
+ },
+ {
"id": "TargetID",
"type": "string"
},
@@ -4252,6 +4256,50 @@
],
"commands": [
{
+ "name": "newBrowserContext",
pfeldman 2016/07/06 17:38:09 createBrowserContext
alex clarke (OOO till 29th) 2016/07/06 20:25:06 Done.
+ "description": "Creates a new empty BrowserContext. Similar to an incognito profile but you can have more than one.",
+ "returns": [
+ { "name": "browserContextId", "$ref": "BrowserContextID", "description": "The id of the context created." }
+ ],
+ "handlers": ["browser"]
+ },
+ {
+ "name": "closeBrowserContext",
pfeldman 2016/07/06 17:38:09 disposeBrowserContext?
alex clarke (OOO till 29th) 2016/07/06 20:25:07 Done.
+ "description": "Closes a BrowserContext, will fail of any open page uses it.",
+ "parameters": [
+ { "name": "browserContextId", "$ref": "BrowserContextID" }
+ ],
+ "returns": [
+ { "name": "success", "type": "boolean" }
+ ],
+ "handlers": ["browser"]
+ },
+ {
+ "name": "newPage",
pfeldman 2016/07/06 17:38:09 createPage
alex clarke (OOO till 29th) 2016/07/06 20:25:06 Dimitri suggested createTarget, does that work for
+ "description": "Creates a new page.",
+ "parameters": [
+ { "name": "initialUrl", "type": "string", "description": "The initial URL the page will be navigated to." },
+ { "name": "width", "type": "integer", "description": "Window width (headless chrome only).", "optional": true },
pfeldman 2016/07/06 17:38:09 Still hesitant about these - my worry is that they
alex clarke (OOO till 29th) 2016/07/06 20:25:07 For regular chrome?
+ { "name": "height", "type": "integer", "description": "Window height (headless chrome only).", "optional": true },
+ { "name": "browserContextId", "$ref": "BrowserContextID", "description": "The browser context to create the page in (headless chrome only).", "optional": true }
+ ],
+ "returns": [
+ { "name": "pageId", "$ref": "TargetID", "description": "The id of the page opened." }
+ ],
+ "handlers": ["browser"]
+ },
+ {
+ "name": "closePage",
dgozman 2016/07/06 18:33:30 I think this works for any target, isn't it? Let's
alex clarke (OOO till 29th) 2016/07/06 20:25:06 Done.
+ "description": "Closes a page.",
+ "parameters": [
+ { "name": "pageId", "$ref": "TargetID" }
+ ],
+ "returns": [
+ { "name": "success", "type": "boolean" }
+ ],
+ "handlers": ["browser"]
+ },
+ {
"name": "getTargets",
"returns": [
{ "name": "targetInfo", "type": "array", "items": { "$ref": "TargetInfo" } }

Powered by Google App Engine
This is Rietveld 408576698