Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: content/browser/devtools/protocol/browser_handler.h

Issue 2119063002: Add commands to manage tabs and contexts to Browser Domain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes for Sami Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/browser_handler.h
diff --git a/content/browser/devtools/protocol/browser_handler.h b/content/browser/devtools/protocol/browser_handler.h
index d4135bc1625a593a7116c734d1cf2744269cf748..90c611515a0b3b81db6cd2c17796d1a85f6197d0 100644
--- a/content/browser/devtools/protocol/browser_handler.h
+++ b/content/browser/devtools/protocol/browser_handler.h
@@ -33,6 +33,15 @@ class BrowserHandler : public DevToolsAgentHostClient {
void SetClient(std::unique_ptr<Client> client);
using TargetInfos = std::vector<scoped_refptr<devtools::browser::TargetInfo>>;
+
+ Response NewBrowserContext(std::string* out_contextId);
+ Response CloseBrowserContext(const std::string& contextId, bool* out_success);
pfeldman 2016/07/06 17:38:09 context_id
alex clarke (OOO till 29th) 2016/07/06 20:25:06 Done.
+ Response NewPage(const std::string& in_initialUrl,
pfeldman 2016/07/06 17:38:09 ditto
alex clarke (OOO till 29th) 2016/07/06 20:25:06 Done.
+ const int* in_width,
pfeldman 2016/07/06 17:38:09 Providing a subset of the device metrics data seem
alex clarke (OOO till 29th) 2016/07/06 20:25:06 I'm not quite sure what you are suggesting. I not
+ const int* in_height,
+ const std::string* in_context,
+ std::string* out_targetId);
+ Response ClosePage(const std::string& targetId, bool* out_success);
Response GetTargets(TargetInfos* infos);
Response Attach(const std::string& targetId);
Response Detach(const std::string& targetId);

Powered by Google App Engine
This is Rietveld 408576698