Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2118273002: Ensure acks are sent for all blocking events. (Closed)

Created:
4 years, 5 months ago by dtapuska
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Ensure acks are sent for all blocking events. It was possible for two touch moves that had acks to get coalesced together and the main thread would only process one and deliver the ack for it. This caused a situation where the hung renderer timer was getting fired because there was an outstanding ack in the count. And this timer forced the omnibox to not go away. A large portion of this change (plumbing the ack_state will go away when I land my multi-thread main_thread_event_queue design); but since this needs to be merged back to M52 this is safest. BUG=616991 Review-Url: https://codereview.chromium.org/2094323002 Cr-Commit-Position: refs/heads/master@{#402703} (cherry picked from commit b08721e61d24d65dce50e40731e08231deb95932) Committed: https://chromium.googlesource.com/chromium/src/+/5041a16e38bf17352fb59d805c2cab35242b549a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -45 lines) Patch
M content/renderer/input/input_event_filter.h View 2 chunks +9 lines, -1 line 0 comments Download
M content/renderer/input/input_event_filter.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M content/renderer/input/input_event_filter_unittest.cc View 4 chunks +16 lines, -8 lines 0 comments Download
M content/renderer/input/input_handler_manager.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_manager.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/input/main_thread_event_queue.h View 5 chunks +21 lines, -1 line 0 comments Download
M content/renderer/input/main_thread_event_queue.cc View 1 chunk +22 lines, -7 lines 0 comments Download
M content/renderer/input/main_thread_event_queue_unittest.cc View 5 chunks +47 lines, -4 lines 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/render_widget_input_handler_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_widget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 5 months ago (2016-07-04 13:12:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5041a16e38bf17352fb59d805c2cab35242b549a.

Powered by Google App Engine
This is Rietveld 408576698