content/renderer/input/render_widget_input_handler.cc - Issue 2118273002: Ensure acks are sent for all blocking events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/input/render_widget_input_handler.cc

Issue 2118273002: Ensure acks are sent for all blocking events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/input/render_widget_input_handler.cc

diff --git a/content/renderer/input/render_widget_input_handler.cc b/content/renderer/input/render_widget_input_handler.cc

index 7a427303a4524558049836dcab19d3dc0ec1b451..25bd40139cae31ad791a195cbc06a2a93b150993 100644

--- a/content/renderer/input/render_widget_input_handler.cc

+++ b/content/renderer/input/render_widget_input_handler.cc

@@ -438,7 +438,7 @@ void RenderWidgetInputHandler::HandleInputEvent(

dispatch_type == DISPATCH_TYPE_NON_BLOCKING_NOTIFY_MAIN) {

// |non_blocking| means it was ack'd already by the InputHandlerProxy

// so let the delegate know the event has been handled.

- delegate_->NotifyInputEventHandled(input_event.type);

+ delegate_->NotifyInputEventHandled(input_event.type, ack_result);

}

if ((dispatch_type == DISPATCH_TYPE_BLOCKING ||