Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: content/renderer/input/render_widget_input_handler_delegate.h

Issue 2118273002: Ensure acks are sent for all blocking events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_ 5 #ifndef CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_
6 #define CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_ 6 #define CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 // Notifies that an overscroll was completed from Blink. 63 // Notifies that an overscroll was completed from Blink.
64 virtual void OnDidOverscroll(const DidOverscrollParams& params) = 0; 64 virtual void OnDidOverscroll(const DidOverscrollParams& params) = 0;
65 65
66 // Called when an ACK is ready to be sent to the input event provider. 66 // Called when an ACK is ready to be sent to the input event provider.
67 virtual void OnInputEventAck( 67 virtual void OnInputEventAck(
68 std::unique_ptr<InputEventAck> input_event_ack) = 0; 68 std::unique_ptr<InputEventAck> input_event_ack) = 0;
69 69
70 // Called when an event with a notify dispatch type 70 // Called when an event with a notify dispatch type
71 // (DISPATCH_TYPE_*_NOTIFY_MAIN) of |handled_type| has been processed 71 // (DISPATCH_TYPE_*_NOTIFY_MAIN) of |handled_type| has been processed
72 // by the main thread. 72 // by the main thread.
73 virtual void NotifyInputEventHandled( 73 virtual void NotifyInputEventHandled(blink::WebInputEvent::Type handled_type,
74 blink::WebInputEvent::Type handled_type) = 0; 74 InputEventAckState ack_result) = 0;
75 75
76 // Notifies the delegate of the |input_handler| managing it. 76 // Notifies the delegate of the |input_handler| managing it.
77 virtual void SetInputHandler(RenderWidgetInputHandler* input_handler) = 0; 77 virtual void SetInputHandler(RenderWidgetInputHandler* input_handler) = 0;
78 78
79 // |show_ime| should be ShowIme::IF_NEEDED iff the update may cause the ime to 79 // |show_ime| should be ShowIme::IF_NEEDED iff the update may cause the ime to
80 // be displayed, e.g. after a tap on an input field on mobile. 80 // be displayed, e.g. after a tap on an input field on mobile.
81 // |change_source| should be ChangeSource::FROM_NON_IME when the renderer has 81 // |change_source| should be ChangeSource::FROM_NON_IME when the renderer has
82 // to wait for the browser to acknowledge the change before the renderer 82 // to wait for the browser to acknowledge the change before the renderer
83 // handles any more IME events. This is when the text change did not originate 83 // handles any more IME events. This is when the text change did not originate
84 // from the IME in the browser side, such as changes by JavaScript or 84 // from the IME in the browser side, such as changes by JavaScript or
(...skipping 11 matching lines...) Expand all
96 // won't be sent to WebKit or trigger DidHandleMouseEvent(). 96 // won't be sent to WebKit or trigger DidHandleMouseEvent().
97 virtual bool WillHandleMouseEvent(const blink::WebMouseEvent& event) = 0; 97 virtual bool WillHandleMouseEvent(const blink::WebMouseEvent& event) = 0;
98 98
99 protected: 99 protected:
100 virtual ~RenderWidgetInputHandlerDelegate() {} 100 virtual ~RenderWidgetInputHandlerDelegate() {}
101 }; 101 };
102 102
103 } // namespace content 103 } // namespace content
104 104
105 #endif // CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_ 105 #endif // CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_
OLDNEW
« no previous file with comments | « content/renderer/input/render_widget_input_handler.cc ('k') | content/renderer/mus/compositor_mus_connection_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698