Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2118163002: Remove ScriptRunner::callFunction (Closed)

Created:
4 years, 5 months ago by haraken
Modified:
4 years, 5 months ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, kinuko+watch, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScriptRunner::callFunction This CL removes another ScriptRunner::callFunction. We should just use V8ScriptRunner::callFunction. BUG= Committed: https://crrev.com/2dce834b0eb8bd92514930a02179ca334051037c Cr-Commit-Position: refs/heads/master@{#403656}

Patch Set 1 #

Patch Set 2 : temp #

Messages

Total messages: 15 (7 generated)
haraken
PTAL
4 years, 5 months ago (2016-07-04 07:49:35 UTC) #2
Yuki
lgtm
4 years, 5 months ago (2016-07-04 08:07:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118163002/20001
4 years, 5 months ago (2016-07-04 08:07:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118163002/20001
4 years, 5 months ago (2016-07-04 08:08:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/98060)
4 years, 5 months ago (2016-07-04 09:09:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118163002/20001
4 years, 5 months ago (2016-07-04 09:23:29 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-04 09:56:25 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 09:58:36 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2dce834b0eb8bd92514930a02179ca334051037c
Cr-Commit-Position: refs/heads/master@{#403656}

Powered by Google App Engine
This is Rietveld 408576698