third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp - Issue 2118163002: Remove ScriptRunner::callFunction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

Issue 2118163002: Remove ScriptRunner::callFunction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

index 9a460ddeb0cf448e40230c7d999b84175ac0fcd8..b35c509c2cf782742d1d87ea594300cda8014b7c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

@@ -116,7 +116,7 @@ v8::Local<v8::Value> V8EventListener::callListenerFunction(ScriptState* scriptSt

v8::Local<v8::Value> parameters[1] = { jsEvent };

v8::Local<v8::Value> result;

- if (!frame->script().callFunction(handlerFunction, receiver, WTF_ARRAY_LENGTH(parameters), parameters).ToLocal(&result))

+ if (!V8ScriptRunner::callFunction(handlerFunction, frame->document(), receiver, WTF_ARRAY_LENGTH(parameters), parameters, scriptState->isolate()).ToLocal(&result))

return v8::Local<v8::Value>();

return result;

}