Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp

Issue 2118163002: Remove ScriptRunner::callFunction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptController.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007-2009 Google Inc. All rights reserved. 2 * Copyright (C) 2007-2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 DVLOG(1) << "ScheduledAction::execute " << this << ": context is empty"; 109 DVLOG(1) << "ScheduledAction::execute " << this << ": context is empty";
110 return; 110 return;
111 } 111 }
112 112
113 TRACE_EVENT0("v8", "ScheduledAction::execute"); 113 TRACE_EVENT0("v8", "ScheduledAction::execute");
114 ScriptState::Scope scope(m_scriptState.get()); 114 ScriptState::Scope scope(m_scriptState.get());
115 if (!m_function.isEmpty()) { 115 if (!m_function.isEmpty()) {
116 DVLOG(1) << "ScheduledAction::execute " << this << ": have function"; 116 DVLOG(1) << "ScheduledAction::execute " << this << ": have function";
117 Vector<v8::Local<v8::Value>> info; 117 Vector<v8::Local<v8::Value>> info;
118 createLocalHandlesForArgs(&info); 118 createLocalHandlesForArgs(&info);
119 frame->script().callFunction(m_function.newLocal(m_scriptState->isolate( )), m_scriptState->context()->Global(), info.size(), info.data()); 119 V8ScriptRunner::callFunction(m_function.newLocal(m_scriptState->isolate( )), frame->document(), m_scriptState->context()->Global(), info.size(), info.dat a(), m_scriptState->isolate());
120 } else { 120 } else {
121 DVLOG(1) << "ScheduledAction::execute " << this << ": executing from sou rce"; 121 DVLOG(1) << "ScheduledAction::execute " << this << ": executing from sou rce";
122 frame->script().executeScriptAndReturnValue(m_scriptState->context(), Sc riptSourceCode(m_code)); 122 frame->script().executeScriptAndReturnValue(m_scriptState->context(), Sc riptSourceCode(m_code));
123 } 123 }
124 124
125 // The frame might be invalid at this point because JavaScript could have re leased it. 125 // The frame might be invalid at this point because JavaScript could have re leased it.
126 } 126 }
127 127
128 void ScheduledAction::execute(WorkerGlobalScope* worker) 128 void ScheduledAction::execute(WorkerGlobalScope* worker)
129 { 129 {
(...skipping 10 matching lines...) Expand all
140 } 140 }
141 141
142 void ScheduledAction::createLocalHandlesForArgs(Vector<v8::Local<v8::Value>>* ha ndles) 142 void ScheduledAction::createLocalHandlesForArgs(Vector<v8::Local<v8::Value>>* ha ndles)
143 { 143 {
144 handles->reserveCapacity(m_info.Size()); 144 handles->reserveCapacity(m_info.Size());
145 for (size_t i = 0; i < m_info.Size(); ++i) 145 for (size_t i = 0; i < m_info.Size(); ++i)
146 handles->append(m_info.Get(i)); 146 handles->append(m_info.Get(i));
147 } 147 }
148 148
149 } // namespace blink 149 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698