Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2117933002:
Update to V8 5.3.345.2 (Closed)
|
Created:
4 years, 5 months ago by Michael Hablich Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate to V8 5.3.345.2
This version includes two fixes for major crashers. NOTRY because test benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:news:cnn even fails with a version which was already deployed to Canary ... test seems to be broken.
TBR=machenbach@chromium.org,vogelheim@chromium.org,littledan@chromium.org
NOTRY=true
Committed: https://crrev.com/02f7f5836dab4f3d269618f9b699f7555221d9b0
Cr-Commit-Position: refs/heads/master@{#403611}
Patch Set 1 #Patch Set 2 : Update to 5.3.345.2 #Patch Set 3 : Update to 5.3.345.1 #Patch Set 4 : Try 5.3.345 which was already rolled in #Patch Set 5 : 5.3.345.2 #Messages
Total messages: 31 (16 generated)
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by hablich@chromium.org
Description was changed from ========== Update/Rollback to V8 5.3.345 Rolling in a V8 version which was already in Chromium until the autoroller is unstuck again. TBR=machenbach@chromium.org,vogelheim@chromium.org,littledan@chromium.org ========== to ========== Update to V8 5.3.345.2 Rolling in a V8 version which was already in Chromium until the autoroller is unstuck again. This version includes two fixes for major crashers. TBR=machenbach@chromium.org,vogelheim@chromium.org,littledan@chromium.org ==========
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Update to V8 5.3.345.2 Rolling in a V8 version which was already in Chromium until the autoroller is unstuck again. This version includes two fixes for major crashers. TBR=machenbach@chromium.org,vogelheim@chromium.org,littledan@chromium.org ========== to ========== Update to V8 5.3.345.1 Rolling in a V8 version which was already in Chromium until the autoroller is unstuck again. This version includes one fix for major crashers. TBR=machenbach@chromium.org,vogelheim@chromium.org,littledan@chromium.org ==========
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hablich@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Update to V8 5.3.345.1 Rolling in a V8 version which was already in Chromium until the autoroller is unstuck again. This version includes one fix for major crashers. TBR=machenbach@chromium.org,vogelheim@chromium.org,littledan@chromium.org ========== to ========== Update to V8 5.3.345.2 This version includes two fixes for major crashers. NOTRY because test benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:news:cnn even fails with a version which was already deployed to Canary ... test seems to be broken. TBR=machenbach@chromium.org,vogelheim@chromium.org,littledan@chromium.org NOTRY=true ==========
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update to V8 5.3.345.2 This version includes two fixes for major crashers. NOTRY because test benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:news:cnn even fails with a version which was already deployed to Canary ... test seems to be broken. TBR=machenbach@chromium.org,vogelheim@chromium.org,littledan@chromium.org NOTRY=true ========== to ========== Update to V8 5.3.345.2 This version includes two fixes for major crashers. NOTRY because test benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:news:cnn even fails with a version which was already deployed to Canary ... test seems to be broken. TBR=machenbach@chromium.org,vogelheim@chromium.org,littledan@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Update to V8 5.3.345.2 This version includes two fixes for major crashers. NOTRY because test benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:news:cnn even fails with a version which was already deployed to Canary ... test seems to be broken. TBR=machenbach@chromium.org,vogelheim@chromium.org,littledan@chromium.org NOTRY=true ========== to ========== Update to V8 5.3.345.2 This version includes two fixes for major crashers. NOTRY because test benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:news:cnn even fails with a version which was already deployed to Canary ... test seems to be broken. TBR=machenbach@chromium.org,vogelheim@chromium.org,littledan@chromium.org NOTRY=true Committed: https://crrev.com/02f7f5836dab4f3d269618f9b699f7555221d9b0 Cr-Commit-Position: refs/heads/master@{#403611} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/02f7f5836dab4f3d269618f9b699f7555221d9b0 Cr-Commit-Position: refs/heads/master@{#403611}
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2116943002/ by dpranke@chromium.org. The reason for reverting is: Speculatively reverting to see if this cleans up some of the other failures. See comments in crbug.com/652506 and linked build failures..
Message was sent while issue was closed.
On 2016/07/04 00:15:41, Dirk Pranke wrote: > A revert of this CL (patchset #5 id:80001) has been created in > https://codereview.chromium.org/2116943002/ by mailto:dpranke@chromium.org. > > The reason for reverting is: Speculatively reverting to see if this cleans up > some of the other failures. See comments in crbug.com/652506 and linked build > failures.. Unfortunately, reverting this seems to introduce new errors, so I'll leave this in for the moment.
Message was sent while issue was closed.
On 2016/07/04 01:28:21, Dirk Pranke wrote: > On 2016/07/04 00:15:41, Dirk Pranke wrote: > > A revert of this CL (patchset #5 id:80001) has been created in > > https://codereview.chromium.org/2116943002/ by mailto:dpranke@chromium.org. > > > > The reason for reverting is: Speculatively reverting to see if this cleans up > > some of the other failures. See comments in crbug.com/652506 and linked build > > failures.. > > Unfortunately, reverting this seems to introduce new errors, so I'll leave this > in for the moment. Also, that should have been crbug.com/625506. |
