Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2116943002: Revert of Update to V8 5.3.345.2 (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update to V8 5.3.345.2 (patchset #5 id:80001 of https://codereview.chromium.org/2117933002/ ) Reason for revert: Speculatively reverting to see if this cleans up some of the other failures. See comments in crbug.com/652506 and linked build failures. Original issue's description: > Update to V8 5.3.345.2 > > This version includes two fixes for major crashers. NOTRY because test benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:news:cnn even fails with a version which was already deployed to Canary ... test seems to be broken. > > TBR=machenbach@chromium.org,vogelheim@chromium.org,littledan@chromium.org > NOTRY=true > > Committed: https://crrev.com/02f7f5836dab4f3d269618f9b699f7555221d9b0 > Cr-Commit-Position: refs/heads/master@{#403611} TBR=littledan@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Dirk Pranke
Created Revert of Update to V8 5.3.345.2
4 years, 5 months ago (2016-07-04 00:15:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116943002/1
4 years, 5 months ago (2016-07-04 00:15:50 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/97940)
4 years, 5 months ago (2016-07-04 01:20:27 UTC) #5
Dirk Pranke
On 2016/07/04 01:20:27, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 5 months ago (2016-07-04 01:27:52 UTC) #6
Dirk Pranke
4 years, 5 months ago (2016-07-04 01:30:41 UTC) #7
On 2016/07/04 01:27:52, Dirk Pranke wrote:
> On 2016/07/04 01:20:27, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
> 
> Hrm, unfortunately reverting this seems to introduce new errors ...

Also, that should have been crbug.com/625506.

Powered by Google App Engine
This is Rietveld 408576698