Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2117833002: Record one more reason that download is canceled (Closed)

Created:
4 years, 5 months ago by qinmin
Modified:
4 years, 5 months ago
Reviewers:
Ted C, Ilya Sherman
CC:
chromium-reviews, darin-cc_chromium.org, jam, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Record one more reason that download is canceled Download was cancelled when a dangerous download infobar is dismissed. We missed it in the previous CL. TBR=isherman@chromium.org,tedchoc@chromium.org BUG=618864 Review-Url: https://codereview.chromium.org/2111983002 Cr-Commit-Position: refs/heads/master@{#403274} (cherry picked from commit 513a888b2e3fb9b99fb623d32d22b6059c93951f) Committed: https://chromium.googlesource.com/chromium/src/+/2959ac849dd9cc9868c2966923803dc3880cee63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M content/browser/android/download_controller_android_impl.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M content/public/browser/android/download_controller_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
4 years, 5 months ago (2016-07-01 17:07:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2959ac849dd9cc9868c2966923803dc3880cee63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698