Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2017)

Unified Diff: content/browser/android/download_controller_android_impl.cc

Issue 2117833002: Record one more reason that download is canceled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/browser/android/download_controller_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/download_controller_android_impl.cc
diff --git a/content/browser/android/download_controller_android_impl.cc b/content/browser/android/download_controller_android_impl.cc
index c0180108451d9c1d04f31f314f7833704f7fb0c1..f6231b3ce1215f08d5c0bdd4408f599c34064aea 100644
--- a/content/browser/android/download_controller_android_impl.cc
+++ b/content/browser/android/download_controller_android_impl.cc
@@ -507,7 +507,7 @@ void DownloadControllerAndroidImpl::OnDownloadUpdated(DownloadItem* item) {
item->GetReceivedBytes(), item->GetId(), jguid.obj(),
joriginal_url.obj(), jreferrer_url.obj(), item->HasUserGesture());
DownloadControllerAndroid::RecordDownloadCancelReason(
- DownloadControllerAndroid::CANCEL_REASON_NOT_CANCELED);
+ DownloadControllerAndroid::CANCEL_REASON_NOT_CANCELED);
break;
case DownloadItem::CANCELLED:
Java_DownloadController_onDownloadCancelled(
@@ -592,10 +592,14 @@ void DownloadControllerAndroidImpl::DangerousDownloadValidated(
DownloadItem* item = dlm->GetDownloadByGuid(download_guid);
if (!item)
return;
- if (accept)
+ if (accept) {
item->ValidateDangerousDownload();
- else
+ } else {
+ DownloadControllerAndroid::RecordDownloadCancelReason(
+ DownloadControllerAndroid::
+ CANCEL_REASON_DANGEROUS_DOWNLOAD_INFOBAR_DISMISSED);
item->Remove();
+ }
}
DownloadControllerAndroidImpl::DownloadInfoAndroid::DownloadInfoAndroid(
« no previous file with comments | « no previous file | content/public/browser/android/download_controller_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698