Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2111983002: Record one more reason that download is canceled (Closed)

Created:
4 years, 5 months ago by qinmin
Modified:
4 years, 5 months ago
Reviewers:
Ted C, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record one more reason that download is canceled Download was cancelled when a dangerous download infobar is dismissed. We missed it in the previous CL. BUG=618864 Committed: https://crrev.com/513a888b2e3fb9b99fb623d32d22b6059c93951f Cr-Commit-Position: refs/heads/master@{#403274}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/android/download/download_controller.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/download/download_controller.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
qinmin
PTAL
4 years, 5 months ago (2016-06-30 17:23:04 UTC) #2
Ilya Sherman
histograms.xml lgtm
4 years, 5 months ago (2016-06-30 17:26:54 UTC) #3
Ilya Sherman
Actually, LGTM with one nit: https://codereview.chromium.org/2111983002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2111983002/diff/1/tools/metrics/histograms/histograms.xml#newcode82372 tools/metrics/histograms/histograms.xml:82372: + <int value="5" label="Dangerous ...
4 years, 5 months ago (2016-06-30 17:27:35 UTC) #4
Ted C
lgtm
4 years, 5 months ago (2016-06-30 17:55:21 UTC) #5
qinmin
https://codereview.chromium.org/2111983002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2111983002/diff/1/tools/metrics/histograms/histograms.xml#newcode82372 tools/metrics/histograms/histograms.xml:82372: + <int value="5" label="Dangerous infobar dismissed"/> On 2016/06/30 17:27:35, ...
4 years, 5 months ago (2016-06-30 19:37:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111983002/20001
4 years, 5 months ago (2016-06-30 19:38:33 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 20:43:54 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 20:44:11 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 20:45:09 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/513a888b2e3fb9b99fb623d32d22b6059c93951f
Cr-Commit-Position: refs/heads/master@{#403274}

Powered by Google App Engine
This is Rietveld 408576698