Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: chrome/common/render_messages.h

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/render_messages.h
diff --git a/chrome/common/render_messages.h b/chrome/common/render_messages.h
index 2241fc2049e588a6771988092bcae762d730c9dc..d754995ce90b792f2980483cf4eff99376fcb2b2 100644
--- a/chrome/common/render_messages.h
+++ b/chrome/common/render_messages.h
@@ -165,6 +165,9 @@ IPC_STRUCT_TRAITS_END()
IPC_ENUM_TRAITS_MAX_VALUE(NTPLoggingEventType,
NTP_EVENT_TYPE_LAST)
+IPC_ENUM_TRAITS_MAX_VALUE(NTPLoggingTileSource,
+ NTPLoggingTileSource::LAST)
+
IPC_ENUM_TRAITS_MAX_VALUE(WebApplicationInfo::MobileCapable,
WebApplicationInfo::MOBILE_CAPABLE_APPLE)
@@ -488,14 +491,14 @@ IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_LogEvent,
IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_LogMostVisitedImpression,
int /* page_seq_no */,
int /* position */,
- base::string16 /* provider */)
+ NTPLoggingTileSource /* tile_source */)
// Logs a navigation on one of the Most Visited tile on the InstantExtended
// New Tab Page.
IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_LogMostVisitedNavigation,
int /* page_seq_no */,
int /* position */,
- base::string16 /* provider */)
+ NTPLoggingTileSource /* tile_source */)
// The Instant page asks whether the user syncs its history.
IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_HistorySyncCheck,
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc ('k') | chrome/common/search/ntp_logging_events.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698