Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: chrome/common/render_messages.h

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Multiply-included file, no traditional include guard. 5 // Multiply-included file, no traditional include guard.
6 #include <stdint.h> 6 #include <stdint.h>
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 IPC_STRUCT_TRAITS_MEMBER(image_vertical_alignment) 158 IPC_STRUCT_TRAITS_MEMBER(image_vertical_alignment)
159 IPC_STRUCT_TRAITS_MEMBER(image_tiling) 159 IPC_STRUCT_TRAITS_MEMBER(image_tiling)
160 IPC_STRUCT_TRAITS_MEMBER(image_height) 160 IPC_STRUCT_TRAITS_MEMBER(image_height)
161 IPC_STRUCT_TRAITS_MEMBER(has_attribution) 161 IPC_STRUCT_TRAITS_MEMBER(has_attribution)
162 IPC_STRUCT_TRAITS_MEMBER(logo_alternate) 162 IPC_STRUCT_TRAITS_MEMBER(logo_alternate)
163 IPC_STRUCT_TRAITS_END() 163 IPC_STRUCT_TRAITS_END()
164 164
165 IPC_ENUM_TRAITS_MAX_VALUE(NTPLoggingEventType, 165 IPC_ENUM_TRAITS_MAX_VALUE(NTPLoggingEventType,
166 NTP_EVENT_TYPE_LAST) 166 NTP_EVENT_TYPE_LAST)
167 167
168 IPC_ENUM_TRAITS_MAX_VALUE(NTPLoggingTileSource,
169 NTPLoggingTileSource::LAST)
170
168 IPC_ENUM_TRAITS_MAX_VALUE(WebApplicationInfo::MobileCapable, 171 IPC_ENUM_TRAITS_MAX_VALUE(WebApplicationInfo::MobileCapable,
169 WebApplicationInfo::MOBILE_CAPABLE_APPLE) 172 WebApplicationInfo::MOBILE_CAPABLE_APPLE)
170 173
171 IPC_STRUCT_TRAITS_BEGIN(WebApplicationInfo::IconInfo) 174 IPC_STRUCT_TRAITS_BEGIN(WebApplicationInfo::IconInfo)
172 IPC_STRUCT_TRAITS_MEMBER(url) 175 IPC_STRUCT_TRAITS_MEMBER(url)
173 IPC_STRUCT_TRAITS_MEMBER(width) 176 IPC_STRUCT_TRAITS_MEMBER(width)
174 IPC_STRUCT_TRAITS_MEMBER(height) 177 IPC_STRUCT_TRAITS_MEMBER(height)
175 IPC_STRUCT_TRAITS_MEMBER(data) 178 IPC_STRUCT_TRAITS_MEMBER(data)
176 IPC_STRUCT_TRAITS_END() 179 IPC_STRUCT_TRAITS_END()
177 180
(...skipping 303 matching lines...) Expand 10 before | Expand all | Expand 10 after
481 IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_LogEvent, 484 IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_LogEvent,
482 int /* page_seq_no */, 485 int /* page_seq_no */,
483 NTPLoggingEventType /* event */, 486 NTPLoggingEventType /* event */,
484 base::TimeDelta /* time */) 487 base::TimeDelta /* time */)
485 488
486 // Logs an impression on one of the Most Visited tile on the InstantExtended 489 // Logs an impression on one of the Most Visited tile on the InstantExtended
487 // New Tab Page. 490 // New Tab Page.
488 IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_LogMostVisitedImpression, 491 IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_LogMostVisitedImpression,
489 int /* page_seq_no */, 492 int /* page_seq_no */,
490 int /* position */, 493 int /* position */,
491 base::string16 /* provider */) 494 NTPLoggingTileSource /* tile_source */)
492 495
493 // Logs a navigation on one of the Most Visited tile on the InstantExtended 496 // Logs a navigation on one of the Most Visited tile on the InstantExtended
494 // New Tab Page. 497 // New Tab Page.
495 IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_LogMostVisitedNavigation, 498 IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_LogMostVisitedNavigation,
496 int /* page_seq_no */, 499 int /* page_seq_no */,
497 int /* position */, 500 int /* position */,
498 base::string16 /* provider */) 501 NTPLoggingTileSource /* tile_source */)
499 502
500 // The Instant page asks whether the user syncs its history. 503 // The Instant page asks whether the user syncs its history.
501 IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_HistorySyncCheck, 504 IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_HistorySyncCheck,
502 int /* page_seq_no */) 505 int /* page_seq_no */)
503 506
504 // The Instant page asks for Chrome identity check against |identity|. 507 // The Instant page asks for Chrome identity check against |identity|.
505 IPC_MESSAGE_ROUTED2(ChromeViewHostMsg_ChromeIdentityCheck, 508 IPC_MESSAGE_ROUTED2(ChromeViewHostMsg_ChromeIdentityCheck,
506 int /* page_seq_no */, 509 int /* page_seq_no */,
507 base::string16 /* identity */) 510 base::string16 /* identity */)
508 511
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
567 570
568 // Record a sample string to a Rappor metric. 571 // Record a sample string to a Rappor metric.
569 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRappor, 572 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRappor,
570 std::string /* metric */, 573 std::string /* metric */,
571 std::string /* sample */) 574 std::string /* sample */)
572 575
573 // Record a domain and registry of a url to a Rappor metric. 576 // Record a domain and registry of a url to a Rappor metric.
574 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRapporURL, 577 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRapporURL,
575 std::string /* metric */, 578 std::string /* metric */,
576 GURL /* sample url */) 579 GURL /* sample url */)
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc ('k') | chrome/common/search/ntp_logging_events.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698