chrome/common/search/ntp_logging_events.h - Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/search/ntp_logging_events.h

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/search/ntp_logging_events.h

diff --git a/chrome/common/search/ntp_logging_events.h b/chrome/common/search/ntp_logging_events.h

index edad751279778dd21ab18b223e25b1245fe60c0e..5bee7dfe64dafc5980ff0b0433038de32812bb49 100644

--- a/chrome/common/search/ntp_logging_events.h

+++ b/chrome/common/search/ntp_logging_events.h

@@ -49,4 +49,14 @@ enum NTPLoggingEventType {

NTP_EVENT_TYPE_LAST = NTP_TILE_LOADED

};

+// The source of an NTP tile.

+// Note: Keep in sync with browser/resources/local_ntp/most_visited_util.js and

+// browser/resources/local_ntp/most_visited_single.js.

+// TODO(treib): Merge this into MostVisitedSource from components/ntp_tiles.

+enum class NTPLoggingTileSource {

+ CLIENT = 0,

+ SERVER = 1,

+ LAST = SERVER

+};

#endif // CHROME_COMMON_SEARCH_NTP_LOGGING_EVENTS_H_

« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/renderer/searchbox/searchbox.h » ('j') | no next file with comments »