Fix build of Widevine CDM stub on Mac

Fix build of Widevine CDM stub on Mac

The combination of 'branding=Chromium' and 'enable_widevine=1' causes
'widevinecdm' to be a 'shared_library' build of the CDM stub.
Additionally combined with 'mac_strip_release=1', this triggers
'strip_save_dsym', which fails, because it doesn't support
'product_dir'.

This fix does to 'widevinecdm' what has already been done to
'clearkeycdm': Split the target into 'widevinecdm_binary' which builds
and strips the stub binary, and 'widevinecdm' which just copies the
binary.

BUG=622282
TEST='build/gyp_chromium -Gconfig=Release -Dbranding=Chromium -Denable_widevine=1 -Dmac_strip_release=1 && ninja -C out/Release widevinecdm' is successful

Committed: https://crrev.com/4b974c6063233f9e9874d5bde97883b8a57af638
Cr-Commit-Position: refs/heads/master@{#405371}

[wdzierzanowski, 2016-07-06 19:13:19]

wdzierzanowski@opera.com changed reviewers:
+ ddorwin@chromium.org, xhwang@chromium.org

[wdzierzanowski, 2016-07-06 19:13:20]

ddorwin: Could you take a look? This is what xhwang was suggesting, but it seems
he's currently OOO.

[ddorwin, 2016-07-08 16:16:44]

LGTM with comment.

https://codereview.chromium.org/2117343005/diff/1/third_party/widevine/cdm/wi...
File third_party/widevine/cdm/widevine_cdm.gyp (right):

https://codereview.chromium.org/2117343005/diff/1/third_party/widevine/cdm/wi...
third_party/widevine/cdm/widevine_cdm.gyp:200: 'product_dir':
'<(PRODUCT_DIR)/<(widevine_cdm_path)',
Also include the bug reference?
 # See http://crbug.com/611990

[wdzierzanowski, 2016-07-08 21:30:47]

Thanks!

Added the bug reference.

https://codereview.chromium.org/2117343005/diff/1/third_party/widevine/cdm/wi...
File third_party/widevine/cdm/widevine_cdm.gyp (right):

https://codereview.chromium.org/2117343005/diff/1/third_party/widevine/cdm/wi...
third_party/widevine/cdm/widevine_cdm.gyp:200: 'product_dir':
'<(PRODUCT_DIR)/<(widevine_cdm_path)',
On 2016/07/08 16:16:44, ddorwin wrote:
> Also include the bug reference?
>  # See http://crbug.com/611990

Done.

[wdzierzanowski, 2016-07-12 07:28:41]

> On 2016/07/08 16:16:44, ddorwin wrote:
> > Also include the bug reference?
> >  # See http://crbug.com/611990
> 
> Done.

ddorwin: Is it all fine now and ready for committing? I'm not sure if I need
another explicit LGTM, so I thought I'd better ask.

[ddorwin, 2016-07-14 00:02:46]

The CQ bit was checked by ddorwin@chromium.org

[ddorwin, 2016-07-14 00:02:46]

lgtm

Thanks for checking. Yes, it was fine to commit after addressing the comment.
I'll CQ it now.

[commit-bot: I haz the power, 2016-07-14 00:03:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 00:48:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 00:48:37]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 00:50:14]

Description was changed from

==========
Fix build of Widevine CDM stub on Mac

The combination of 'branding=Chromium' and 'enable_widevine=1' causes
'widevinecdm' to be a 'shared_library' build of the CDM stub.
Additionally combined with 'mac_strip_release=1', this triggers
'strip_save_dsym', which fails, because it doesn't support
'product_dir'.

This fix does to 'widevinecdm' what has already been done to
'clearkeycdm': Split the target into 'widevinecdm_binary' which builds
and strips the stub binary, and 'widevinecdm' which just copies the
binary.

BUG=622282

TEST='build/gyp_chromium -Gconfig=Release -Dbranding=Chromium
-Denable_widevine=1 -Dmac_strip_release=1 && ninja -C out/Release widevinecdm'
is successful
==========

to

==========
Fix build of Widevine CDM stub on Mac

The combination of 'branding=Chromium' and 'enable_widevine=1' causes
'widevinecdm' to be a 'shared_library' build of the CDM stub.
Additionally combined with 'mac_strip_release=1', this triggers
'strip_save_dsym', which fails, because it doesn't support
'product_dir'.

This fix does to 'widevinecdm' what has already been done to
'clearkeycdm': Split the target into 'widevinecdm_binary' which builds
and strips the stub binary, and 'widevinecdm' which just copies the
binary.

BUG=622282

TEST='build/gyp_chromium -Gconfig=Release -Dbranding=Chromium
-Denable_widevine=1 -Dmac_strip_release=1 && ninja -C out/Release widevinecdm'
is successful

Committed: https://crrev.com/4b974c6063233f9e9874d5bde97883b8a57af638
Cr-Commit-Position: refs/heads/master@{#405371}
==========

[commit-bot: I haz the power, 2016-07-14 00:50:15]

Patchset 2 (id:??) landed as
https://crrev.com/4b974c6063233f9e9874d5bde97883b8a57af638
Cr-Commit-Position: refs/heads/master@{#405371}

[yosin_UTC9, 2016-07-14 05:36:02]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2150853002/ by yosin@chromium.org.

The reason for reverting is: Build failure in win-asan bot:

https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/bui...

ninja -w dupbuild=err -C C:\b\build\slave\win-asan\build\src\out\Release
chrome_official_builder
ninja: Entering directory `C:\b\build\slave\win-asan\build\src\out\Release'
[Error 2] The system cannot find the file specified:
'C:\\b\\build\\slave\\win-asan\\build\\src\\out\\Release\\.ninja_log'
ninja: error: obj\third_party\widevine\cdm\widevinecdm_binary.ninja:108:
multiple rules generate WidevineCdm/_platform_specific/win_x86/widevinecdm.dll
[-w dupbuild=err]
.

[wdzierzanowski, 2016-07-14 20:33:56]

Reland CL created: https://codereview.chromium.org/2150043003/