Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2150853002: Revert of Fix build of Widevine CDM stub on Mac (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
CC:
chromium-reviews, eme-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix build of Widevine CDM stub on Mac (patchset #2 id:20001 of https://codereview.chromium.org/2117343005/ ) Reason for revert: Build failure in win-asan bot: https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/builds/313/steps/compile/logs/stdio ninja -w dupbuild=err -C C:\b\build\slave\win-asan\build\src\out\Release chrome_official_builder ninja: Entering directory `C:\b\build\slave\win-asan\build\src\out\Release' [Error 2] The system cannot find the file specified: 'C:\\b\\build\\slave\\win-asan\\build\\src\\out\\Release\\.ninja_log' ninja: error: obj\third_party\widevine\cdm\widevinecdm_binary.ninja:108: multiple rules generate WidevineCdm/_platform_specific/win_x86/widevinecdm.dll [-w dupbuild=err] Original issue's description: > Fix build of Widevine CDM stub on Mac > > The combination of 'branding=Chromium' and 'enable_widevine=1' causes > 'widevinecdm' to be a 'shared_library' build of the CDM stub. > Additionally combined with 'mac_strip_release=1', this triggers > 'strip_save_dsym', which fails, because it doesn't support > 'product_dir'. > > This fix does to 'widevinecdm' what has already been done to > 'clearkeycdm': Split the target into 'widevinecdm_binary' which builds > and strips the stub binary, and 'widevinecdm' which just copies the > binary. > > BUG=622282 > > TEST='build/gyp_chromium -Gconfig=Release -Dbranding=Chromium -Denable_widevine=1 -Dmac_strip_release=1 && ninja -C out/Release widevinecdm' is successful > > Committed: https://crrev.com/4b974c6063233f9e9874d5bde97883b8a57af638 > Cr-Commit-Position: refs/heads/master@{#405371} TBR=ddorwin@chromium.org,xhwang@chromium.org,wdzierzanowski@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622282 Committed: https://crrev.com/d02d6024aa81ad854ad407d3b7525bd73b84b251 Cr-Commit-Position: refs/heads/master@{#405438}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -45 lines) Patch
M third_party/widevine/cdm/widevine_cdm.gyp View 2 chunks +24 lines, -45 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
Created Revert of Fix build of Widevine CDM stub on Mac
4 years, 5 months ago (2016-07-14 05:36:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150853002/1
4 years, 5 months ago (2016-07-14 05:36:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 05:36:51 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 05:38:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d02d6024aa81ad854ad407d3b7525bd73b84b251
Cr-Commit-Position: refs/heads/master@{#405438}

Powered by Google App Engine
This is Rietveld 408576698