Reland of "Fix build of Widevine CDM stub on Mac"

Reland of "Fix build of Widevine CDM stub on Mac"

The combination of 'branding=Chromium' and 'enable_widevine=1' causes
'widevinecdm' to be a 'shared_library' build of the CDM stub.
Additionally combined with 'mac_strip_release=1', this triggers
'strip_save_dsym', which fails, because it doesn't support
'product_dir'.

This fix does to 'widevinecdm' what has already been done to
'clearkeycdm': Split the target into 'widevinecdm_binary' which builds
and strips the stub binary, and 'widevinecdm' which just copies the
binary.

This CL relands https://codereview.chromium.org/2117343005/ with the
following change:

The new 'widevinecdm_binary' target is now defined conditionally for the
case when it is really needed, to fix the ninja error "multiple rules
generate WidevineCdm/_platform_specific/win_x86/widevinecdm.dll".

BUG=622282
TEST='build/gyp_chromium -Gconfig=Release -Dbranding=Chromium -Denable_widevine=1 -Dmac_strip_release=1 && ninja -C out/Release widevinecdm' is successful

[wdzierzanowski, 2016-07-14 20:33:22]

wdzierzanowski@opera.com changed reviewers:
+ ddorwin@chromium.org

[wdzierzanowski, 2016-07-14 20:33:22]

ddorwin: I fixed the "multiple rules generate..." error and I'm trying to reland
the CL. PTAL.

[ddorwin, 2016-07-14 20:37:06]

Please upload the original code as the first patchset then the fix as the second
patchset. Alternatively, you can upload a new patch set to the original review
and reuse it.

[wdzierzanowski, 2016-07-14 21:24:20]

On 2016/07/14 20:37:06, ddorwin wrote:
> Please upload the original code as the first patchset then the fix as the
second
> patchset. Alternatively, you can upload a new patch set to the original review
> and reuse it.

Alright then: https://codereview.chromium.org/2149233003/

[wdzierzanowski, 2016-07-14 21:24:31]

Description was changed from

==========
Reland of "Fix build of Widevine CDM stub on Mac"

The combination of 'branding=Chromium' and 'enable_widevine=1' causes
'widevinecdm' to be a 'shared_library' build of the CDM stub.
Additionally combined with 'mac_strip_release=1', this triggers
'strip_save_dsym', which fails, because it doesn't support
'product_dir'.

This fix does to 'widevinecdm' what has already been done to
'clearkeycdm': Split the target into 'widevinecdm_binary' which builds
and strips the stub binary, and 'widevinecdm' which just copies the
binary.

This CL relands https://codereview.chromium.org/2117343005/ with the
following change:

The new 'widevinecdm_binary' target is now defined conditionally for the
case when it is really needed, to fix the ninja error "multiple rules
generate WidevineCdm/_platform_specific/win_x86/widevinecdm.dll".

BUG=622282

TEST='build/gyp_chromium -Gconfig=Release -Dbranding=Chromium
-Denable_widevine=1 -Dmac_strip_release=1 && ninja -C out/Release widevinecdm'
is successful
==========

to

==========
Reland of "Fix build of Widevine CDM stub on Mac"

The combination of 'branding=Chromium' and 'enable_widevine=1' causes
'widevinecdm' to be a 'shared_library' build of the CDM stub.
Additionally combined with 'mac_strip_release=1', this triggers
'strip_save_dsym', which fails, because it doesn't support
'product_dir'.

This fix does to 'widevinecdm' what has already been done to
'clearkeycdm': Split the target into 'widevinecdm_binary' which builds
and strips the stub binary, and 'widevinecdm' which just copies the
binary.

This CL relands https://codereview.chromium.org/2117343005/ with the
following change:

The new 'widevinecdm_binary' target is now defined conditionally for the
case when it is really needed, to fix the ninja error "multiple rules
generate WidevineCdm/_platform_specific/win_x86/widevinecdm.dll".

BUG=622282

TEST='build/gyp_chromium -Gconfig=Release -Dbranding=Chromium
-Denable_widevine=1 -Dmac_strip_release=1 && ninja -C out/Release widevinecdm'
is successful
==========