Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2117323002:
Disable Linux key storage for non-glib builds (Closed)
DescriptionDisable Linux key storage for non-glib builds
The Linux key storage implementation depends on
libsecret. This change fixes the build issues with
ozone enabled (glib disabled).
BUG=
Patch Set 1 #
Total comments: 2
Messages
Total messages: 24 (14 generated)
The CQ bit was checked by zoltan.kuscsik@linaro.org
The CQ bit was unchecked by zoltan.kuscsik@linaro.org
The CQ bit was checked by zoltan.kuscsik@linaro.org to run a CQ dry run
The CQ bit was unchecked by zoltan.kuscsik@linaro.org
The CQ bit was checked by zoltan.kuscsik@linaro.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Disable Linux key storage for non-glib builds The Linux key storage implementation depends on libsecret. This change fixes the build issues with ozone enabled (glib disabled). BUG= ========== to ========== Disable Linux key storage for non-glib builds The Linux key storage implementation depends on libsecret. This change fixes the build issues with ozone enabled (glib disabled). BUG= ==========
zoltan.kuscsik@linaro.org changed reviewers: + thestig@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Disable Linux key storage for non-glib builds The Linux key storage implementation depends on libsecret. This change fixes the build issues with ozone enabled (glib disabled). BUG= ========== to ========== Disable Linux key storage for non-glib builds The Linux key storage implementation depends on libsecret. This change fixes the build issues with ozone enabled (glib disabled). BUG= ==========
zoltan.kuscsik@linaro.org changed reviewers: + thestig@google.com
zoltan.kuscsik@linaro.org changed reviewers: + thestig@chromium.org - thestig@google.com
The CQ bit was checked by zoltan.kuscsik@linaro.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
thestig@chromium.org changed reviewers: + cfroussios@chromium.org
+cfroussios as reviewer zoli: What build configuration are you using exactly? Is there a Chromium buildbot that builds your ozone configuration? If not, then your build config is rather fragile and can break easily. The Ozone build that we test with (AFAIK) is https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%... and it's green.
Hi zoli! As Lei already pointed out, it would be helpful to know which bot checks this build. There is more work under way that could break this again. https://codereview.chromium.org/2117323002/diff/1/components/os_crypt/BUILD.gn File components/os_crypt/BUILD.gn (right): https://codereview.chromium.org/2117323002/diff/1/components/os_crypt/BUILD.g... components/os_crypt/BUILD.gn:47: if (is_desktop_linux && (use_glib)) { I don't think this is where your problem starts. The dependency on glib is already hidden behind "if (use_glib)". If you used USE_LIBSECRET in components/os_crypt/key_storage_linux.cc would it solve your problem?
https://codereview.chromium.org/2117323002/diff/1/components/os_crypt/BUILD.gn File components/os_crypt/BUILD.gn (right): https://codereview.chromium.org/2117323002/diff/1/components/os_crypt/BUILD.g... components/os_crypt/BUILD.gn:47: if (is_desktop_linux && (use_glib)) { On 2016/07/07 10:59:50, cfroussios wrote: > I don't think this is where your problem starts. The dependency on glib is > already hidden behind "if (use_glib)". > > If you used USE_LIBSECRET in > components/os_crypt/key_storage_linux.cc > would it solve your problem? I should clarify: just make KeyStorageLinux::CreateService() return nullptr if the flag is not set.
On 2016/07/07 11:05:29, cfroussios wrote: > https://codereview.chromium.org/2117323002/diff/1/components/os_crypt/BUILD.gn > File components/os_crypt/BUILD.gn (right): > > https://codereview.chromium.org/2117323002/diff/1/components/os_crypt/BUILD.g... > components/os_crypt/BUILD.gn:47: if (is_desktop_linux && (use_glib)) { > On 2016/07/07 10:59:50, cfroussios wrote: > > I don't think this is where your problem starts. The dependency on glib is > > already hidden behind "if (use_glib)". > > > > If you used USE_LIBSECRET in > > components/os_crypt/key_storage_linux.cc > > would it solve your problem? > > I should clarify: just make KeyStorageLinux::CreateService() return nullptr if > the flag is not set. I'm working on ozone enabled/X11-disabled builds for Linux-Wayland. My primary build target is ARMv8. The origin of the issue is that with use_ozone enabled on Linux, glib is disabled: file:///build/config/ui.gni:73>> if (use_ozone) { use_glib = false } The patch is related to support the upstream work of wayland-ozone project: https://codereview.chromium.org/2027943002/ I will make the update of the KeyStorageLinux::CreateService() as you suggested and push a new patch
Hi! Is this still a problem? If not, it would be nice to close inactive issues. Thanks a lot! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
