[WIP] Make content_shell run under Wayland

ozone/platform/wayland: Make content_shell run under Wayland

This is upstream work for the ozone-wayland project:
https://github.com/01org/ozone-wayland

BUG=578890
This CL includes the following CLs to make content_shell work:
https://codereview.chromium.org/2024953007/

Here are GN build arguments for building content_shell:

use_ozone= true
ozone_platform_wayland= true
use_wayland_egl= false

Build & Run
$ gn args out/Release
$ ninja -C out/Release content_shell
$ out/Release/content_shell --ozone-platform=wayland

[joone, 2016-06-01 08:03:42]

Patchset #1 (id:1) has been deleted

[joone, 2016-06-01 08:08:49]

Patchset #1 (id:20001) has been deleted

[joone, 2016-06-01 08:12:53]

Description was changed from

==========
ozone/platform/wayland: Make content_shell run under Wayland

BUG=578890
==========

to

==========
ozone/platform/wayland: Make content_shell run under Wayland

This is upstream work for the ozone-wayland project:
https://github.com/01org/ozone-wayland

BUG=578890
==========

[joone, 2016-06-01 18:27:51]

Patchset #1 (id:40001) has been deleted

[joone, 2016-06-01 20:26:35]

joone.hur@intel.com changed reviewers:
+ reveman@chromium.org

[joone, 2016-06-01 20:26:36]

Hi, I'm trying to run content_shell under Wayland. Currently, It works in
Weston, but it can be only maximized and restored. I'm planning to split this CL
into 2 or 3 and add more features. Please take a look at this CL.

[Michael Forney, 2016-06-01 20:48:02]

Please make the corresponding changes to BUILD.gn so that the gn build doesn't
break.

Also, you might want to coordinate with tonikitoo, who is doing similar work:
http://crrev.com/2024953007

Is any of this testable? If so, you should write some tests.

https://codereview.chromium.org/2027943002/diff/60001/ui/ozone/platform/wayla...
File ui/ozone/platform/wayland/wayland_object.cc (right):

https://codereview.chromium.org/2027943002/diff/60001/ui/ozone/platform/wayla...
ui/ozone/platform/wayland/wayland_object.cc:45: void
(*ObjectTraits<wl_output>::deleter)(wl_output*) = &delete_output;
Just use &wl_output_destroy here.

[joone, 2016-06-03 22:43:10]

forney@ thanks for the review. Here is the separate CL that includes the changes
in ui/ozone/platform/wayland:
https://codereview.chromium.org/2042503002

I also added a test case.

https://codereview.chromium.org/2027943002/diff/60001/ui/ozone/platform/wayla...
File ui/ozone/platform/wayland/wayland_object.cc (right):

https://codereview.chromium.org/2027943002/diff/60001/ui/ozone/platform/wayla...
ui/ozone/platform/wayland/wayland_object.cc:45: void
(*ObjectTraits<wl_output>::deleter)(wl_output*) = &delete_output;
On 2016/06/01 20:48:01, Michael Forney wrote:
> Just use &wl_output_destroy here.

Done.

[tonikitoo, 2016-06-06 15:29:58]

tonikitoo@igalia.com changed reviewers:
+ tonikitoo@igalia.com

[tonikitoo, 2016-06-06 15:29:59]

hi joone. This looks promising. I have left some overall comments, but this is
how I believe we should proceed with upstreaming this:

- get https://codereview.chromium.org/2024953007/ merged (hopefully reviews also
like the idea).
- start upstreaming an skeleton of both DesktopScreenWayland and
DesktopWindowTreeHostWayland.
- implement DesktopFactoryOzoneWayland::CreateWindowTreeHost and
DesktopFactoryOzoneWayland::CreateDesktopScreen 
returning the proper Wayland variant of the objects.

This should be enough to get content_shell building / running with Weston.

- continue to upstream the rest of the classes, if the design is approved
overall (wayland_screen, etc).
- start adding d&g support
- etc. 

As one can see, it might be a exhaustive work, but I believe would happen smooth
and could get reviewed without too much trouble.

What do you think?

https://codereview.chromium.org/2027943002/diff/60001/ui/ozone/platform/wayla...
File ui/ozone/platform/wayland/ozone_platform_wayland.cc (right):

https://codereview.chromium.org/2027943002/diff/60001/ui/ozone/platform/wayla...
ui/ozone/platform/wayland/ozone_platform_wayland.cc:84:
desktop_factory_.reset(new views::DesktopFactoryOzoneWayland());
I joone. For the record, this is the biggest goal of
https://codereview.chromium.org/2024953007/ .

Ideally, DesktopFactoryOzone{Platform} should be picked up at runtime, in
accordance to --ozone-platform={platform} .. OR the default platform, if none is
specified at runtime.

https://codereview.chromium.org/2027943002/diff/60001/ui/ozone/platform/wayla...
ui/ozone/platform/wayland/ozone_platform_wayland.cc:85:
views::DesktopFactoryOzone::SetInstance(desktop_factory_.get());
Also, https://codereview.chromium.org/2024953007/ eliminates SetInstance making
the DesktopFactoryOzone{Bleh} instance a known leaky object. This is a similar
pattern than OzonePlatform{Bleh}.

What do you think of this design?

https://codereview.chromium.org/2027943002/diff/60001/ui/ozone/platform/wayla...
ui/ozone/platform/wayland/ozone_platform_wayland.cc:99:
std::unique_ptr<views::DesktopFactoryOzone> desktop_factory_;
Ideally ozone/platform should not depend on ui/views/widget. That was my main
motivation in the https://codereview.chromium.org/2024953007/.

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_drag_drop_client_wayland.h (right):

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_drag_drop_client_wayland.h:14: class
VIEWS_EXPORT DesktopDragDropClientWayland
I believe we should start with the basis at this time, and leave DesktopDragDrop
support for a follow up patch.

By "basis" here I mean:

- DesktopScreenWayland
- DesktopWindowTreeHostWayland

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_factory_wayland.cc (right):

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_factory_wayland.cc:16:
DesktopFactoryOzoneWayland::DesktopFactoryOzoneWayland() {
For the record, this duplicates https://codereview.chromium.org/2024953007/.

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_factory_wayland.h (right):

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_factory_wayland.h:26: class VIEWS_EXPORT
DesktopFactoryOzoneWayland : public DesktopFactoryOzone {
For the record, it duplicates https://codereview.chromium.org/2024953007/.

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_screen_wayland.cc (right):

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_screen_wayland.cc:19: displays_(),
Is this needed?

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_screen_wayland.cc:25: SetGeometry(0,
gfx::Rect(0, 0, 0, 0));
Question: Is this call here temporarily for the reason of avoid an initial crash
(as I also faced it)? Or it is actually needed on the long run?

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_screen_wayland.h (right):

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_screen_wayland.h:10: 
nit: drop empty line.

[joone, 2016-06-06 18:22:22]

tonikitoo, thanks for the review. I will update the CL soon.

https://codereview.chromium.org/2027943002/diff/60001/ui/ozone/platform/wayla...
File ui/ozone/platform/wayland/ozone_platform_wayland.cc (right):

https://codereview.chromium.org/2027943002/diff/60001/ui/ozone/platform/wayla...
ui/ozone/platform/wayland/ozone_platform_wayland.cc:85:
views::DesktopFactoryOzone::SetInstance(desktop_factory_.get());
On 2016/06/06 15:29:59, tonikitoo1 wrote:
> Also, https://codereview.chromium.org/2024953007/ eliminates SetInstance
making
> the DesktopFactoryOzone{Bleh} instance a known leaky object. This is a similar
> pattern than OzonePlatform{Bleh}.
> 
> What do you think of this design?

Great.

https://codereview.chromium.org/2027943002/diff/60001/ui/ozone/platform/wayla...
ui/ozone/platform/wayland/ozone_platform_wayland.cc:99:
std::unique_ptr<views::DesktopFactoryOzone> desktop_factory_;
On 2016/06/06 15:29:59, tonikitoo1 wrote:
> Ideally ozone/platform should not depend on ui/views/widget. That was my main
> motivation in the https://codereview.chromium.org/2024953007/.

Yes, I like your approach.

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_drag_drop_client_wayland.h (right):

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_drag_drop_client_wayland.h:14: class
VIEWS_EXPORT DesktopDragDropClientWayland
On 2016/06/06 15:29:59, tonikitoo1 wrote:
> I believe we should start with the basis at this time, and leave
DesktopDragDrop
> support for a follow up patch.
> 
> By "basis" here I mean:
> 
> - DesktopScreenWayland
> - DesktopWindowTreeHostWayland

Ok, I will add DesktopDragDropClientWayland later.

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_factory_wayland.cc (right):

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_factory_wayland.cc:16:
DesktopFactoryOzoneWayland::DesktopFactoryOzoneWayland() {
On 2016/06/06 15:29:59, tonikitoo1 wrote:
> For the record, this duplicates https://codereview.chromium.org/2024953007/.

Acknowledged.

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_screen_wayland.cc (right):

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_screen_wayland.cc:19: displays_(),
On 2016/06/06 15:29:59, tonikitoo1 wrote:
> Is this needed?

It needs to initialize the vector.

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_screen_wayland.cc:25: SetGeometry(0,
gfx::Rect(0, 0, 0, 0));
On 2016/06/06 15:29:59, tonikitoo1 wrote:
> Question: Is this call here temporarily for the reason of avoid an initial
crash
> (as I also faced it)? Or it is actually needed on the long run?

Yes, it allows us to avoid the initial crash.

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_screen_wayland.h (right):

https://codereview.chromium.org/2027943002/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_screen_wayland.h:10: 
On 2016/06/06 15:29:59, tonikitoo1 wrote:
> nit: drop empty line.

Acknowledged.

[joone, 2016-06-08 00:14:18]

Description was changed from

==========
ozone/platform/wayland: Make content_shell run under Wayland

This is upstream work for the ozone-wayland project:
https://github.com/01org/ozone-wayland

BUG=578890
==========

to

==========
ozone/platform/wayland: Make content_shell run under Wayland

This is upstream work for the ozone-wayland project:
https://github.com/01org/ozone-wayland

BUG=578890

The current CL includes the following CLs to make content_shell work:

https://codereview.chromium.org/2042503002/
https://codereview.chromium.org/2024953007/
==========

[joone, 2016-06-08 01:39:41]

Patchset #2 (id:80001) has been deleted

[zoli, 2016-07-18 06:53:32]

zoltan.kuscsik@linaro.org changed reviewers:
+ zoltan.kuscsik@linaro.org

[zoli, 2016-07-18 06:53:33]

https://codereview.chromium.org/2027943002/diff/100001/ui/aura/window_tree_ho...
File ui/aura/window_tree_host.cc (right):

https://codereview.chromium.org/2027943002/diff/100001/ui/aura/window_tree_ho...
ui/aura/window_tree_host.cc:67:
display::Screen::GetScreen()->WaitForScreenSizeAvailable();
Missing dependency on //ui/display. This will break the component builds.

[reveman, 2016-07-18 17:22:48]

reveman@chromium.org changed reviewers:
+ hoegsberg@chromium.org

[reveman, 2016-07-18 17:22:49]

+hoegsberg

[joone, 2016-07-19 20:46:27]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 20:47:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 20:58:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 20:58:29]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[joone, 2016-07-26 23:38:15]

Patchset #4 (id:140001) has been deleted

[joone, 2016-09-19 22:33:09]

Patchset #5 (id:180001) has been deleted

[joone, 2016-09-19 22:43:09]

Patchset #5 (id:200001) has been deleted

[joone, 2016-09-19 22:51:35]

Patchset #5 (id:220001) has been deleted

[joone, 2016-09-20 17:01:41]

Description was changed from

==========
ozone/platform/wayland: Make content_shell run under Wayland

This is upstream work for the ozone-wayland project:
https://github.com/01org/ozone-wayland

BUG=578890

The current CL includes the following CLs to make content_shell work:

https://codereview.chromium.org/2042503002/
https://codereview.chromium.org/2024953007/
==========

to

==========
ozone/platform/wayland: Make content_shell run under Wayland

This is upstream work for the ozone-wayland project:
https://github.com/01org/ozone-wayland

BUG=578890

The current CL includes the following CLs to make content_shell work:

https://codereview.chromium.org/2042503002/
https://codereview.chromium.org/2024953007/

Here are GN build arguments for building content_shell:

use_ozone= true
ozone_platform_wayland= true
use_wayland_egl= false

Build
$ gn args out/Release
$ ninja -C out/Release content_shell
==========

[joone, 2016-09-20 23:52:21]

Description was changed from

==========
ozone/platform/wayland: Make content_shell run under Wayland

This is upstream work for the ozone-wayland project:
https://github.com/01org/ozone-wayland

BUG=578890

The current CL includes the following CLs to make content_shell work:

https://codereview.chromium.org/2042503002/
https://codereview.chromium.org/2024953007/

Here are GN build arguments for building content_shell:

use_ozone= true
ozone_platform_wayland= true
use_wayland_egl= false

Build
$ gn args out/Release
$ ninja -C out/Release content_shell
==========

to

==========
ozone/platform/wayland: Make content_shell run under Wayland

This is upstream work for the ozone-wayland project:
https://github.com/01org/ozone-wayland

BUG=578890

The current CL includes the following CLs to make content_shell work:

https://codereview.chromium.org/2042503002/
https://codereview.chromium.org/2024953007/

Here are GN build arguments for building content_shell:

use_ozone= true
ozone_platform_wayland= true
use_wayland_egl= false

Build & Run
$ gn args out/Release
$ ninja -C out/Release content_shell
$ out/Release/content_shell --ozone-platform=wayland
==========

[joone, 2016-09-23 18:28:32]

Description was changed from

==========
ozone/platform/wayland: Make content_shell run under Wayland

This is upstream work for the ozone-wayland project:
https://github.com/01org/ozone-wayland

BUG=578890

The current CL includes the following CLs to make content_shell work:

https://codereview.chromium.org/2042503002/
https://codereview.chromium.org/2024953007/

Here are GN build arguments for building content_shell:

use_ozone= true
ozone_platform_wayland= true
use_wayland_egl= false

Build & Run
$ gn args out/Release
$ ninja -C out/Release content_shell
$ out/Release/content_shell --ozone-platform=wayland
==========

to

==========
ozone/platform/wayland: Make content_shell run under Wayland

This is upstream work for the ozone-wayland project:
https://github.com/01org/ozone-wayland

BUG=578890

This CL includes the following CLs to make content_shell work:

https://codereview.chromium.org/2042503002/
https://codereview.chromium.org/2024953007/

Here are GN build arguments for building content_shell:

use_ozone= true
ozone_platform_wayland= true
use_wayland_egl= false

Build & Run
$ gn args out/Release
$ ninja -C out/Release content_shell
$ out/Release/content_shell --ozone-platform=wayland
==========

[joone, 2016-09-28 15:29:10]

Description was changed from

==========
ozone/platform/wayland: Make content_shell run under Wayland

This is upstream work for the ozone-wayland project:
https://github.com/01org/ozone-wayland

BUG=578890

This CL includes the following CLs to make content_shell work:

https://codereview.chromium.org/2042503002/
https://codereview.chromium.org/2024953007/

Here are GN build arguments for building content_shell:

use_ozone= true
ozone_platform_wayland= true
use_wayland_egl= false

Build & Run
$ gn args out/Release
$ ninja -C out/Release content_shell
$ out/Release/content_shell --ozone-platform=wayland
==========

to

==========
ozone/platform/wayland: Make content_shell run under Wayland

This is upstream work for the ozone-wayland project:
https://github.com/01org/ozone-wayland

BUG=578890

This CL includes the following CLs to make content_shell work:
https://codereview.chromium.org/2024953007/

Here are GN build arguments for building content_shell:

use_ozone= true
ozone_platform_wayland= true
use_wayland_egl= false

Build & Run
$ gn args out/Release
$ ninja -C out/Release content_shell
$ out/Release/content_shell --ozone-platform=wayland
==========

[joone, 2016-10-10 19:36:40]

Landed https://codereview.chromium.org/2042503002/ and rebased this CL on it.