extensions/browser/api/dns/dns_api.h - Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/dns/dns_api.h

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: http_stream_factory_impl_job_controller_unittest RequestHandle* to unique_ptr Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromeos/network/host_resolver_impl_chromeos_unittest.cc ('k') | extensions/browser/api/dns/dns_api.cc » ('j') | net/proxy/proxy_resolver_v8_tracing.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/dns/dns_api.h

diff --git a/extensions/browser/api/dns/dns_api.h b/extensions/browser/api/dns/dns_api.h

index ca82c86b07601069fc1e0f2b7fd8ab98a0b1aeda..f77a14f8d99845682c9ebb8e8d240021b4b2ab95 100644

--- a/extensions/browser/api/dns/dns_api.h

+++ b/extensions/browser/api/dns/dns_api.h

@@ -43,7 +43,7 @@ class DnsResolveFunction : public AsyncExtensionFunction {

bool response_; // The value sent in SendResponse().

- std::unique_ptr<net::HostResolver::RequestHandle> request_handle_;

+ std::unique_ptr<net::HostResolver::Request> request_;

std::unique_ptr<net::AddressList> addresses_;

};