Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3541)

Unified Diff: extensions/browser/api/dns/dns_api.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: http_stream_factory_impl_job_controller_unittest RequestHandle* to unique_ptr Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/dns/dns_api.cc
diff --git a/extensions/browser/api/dns/dns_api.cc b/extensions/browser/api/dns/dns_api.cc
index 671254ba4026dc861652631cc4563b53484984f0..cae9e6c2bd01c359ce6f6b05a0eb6212a09cbc01 100644
--- a/extensions/browser/api/dns/dns_api.cc
+++ b/extensions/browser/api/dns/dns_api.cc
@@ -23,10 +23,7 @@ namespace Resolve = extensions::api::dns::Resolve;
namespace extensions {
DnsResolveFunction::DnsResolveFunction()
- : resource_context_(NULL),
- response_(false),
- request_handle_(new net::HostResolver::RequestHandle()),
- addresses_(new net::AddressList) {}
+ : resource_context_(), response_(false), addresses_(new net::AddressList) {}
DnsResolveFunction::~DnsResolveFunction() {}
@@ -60,11 +57,8 @@ void DnsResolveFunction::WorkOnIOThread() {
net::HostResolver::RequestInfo request_info(host_port_pair);
int resolve_result = host_resolver->Resolve(
- request_info,
- net::DEFAULT_PRIORITY,
- addresses_.get(),
- base::Bind(&DnsResolveFunction::OnLookupFinished, this),
- request_handle_.get(),
+ request_info, net::DEFAULT_PRIORITY, addresses_.get(),
+ base::Bind(&DnsResolveFunction::OnLookupFinished, this), &request_,
net::BoundNetLog());
// Balanced in OnLookupFinished.

Powered by Google App Engine
This is Rietveld 408576698