Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: chromeos/network/host_resolver_impl_chromeos_unittest.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: http_stream_factory_impl_job_controller_unittest RequestHandle* to unique_ptr Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/host_resolver_impl_chromeos_unittest.cc
diff --git a/chromeos/network/host_resolver_impl_chromeos_unittest.cc b/chromeos/network/host_resolver_impl_chromeos_unittest.cc
index 897376b3ec0ca926da145455e82b3b10fd201366..3b02ac154f85d61c836c6dfdf6abaf32db90d993 100644
--- a/chromeos/network/host_resolver_impl_chromeos_unittest.cc
+++ b/chromeos/network/host_resolver_impl_chromeos_unittest.cc
@@ -101,13 +101,9 @@ class HostResolverImplChromeOSTest : public testing::Test {
// Run from IO message loop.
void Resolve(net::HostResolver::RequestInfo info) {
- result_ = host_resolver_->Resolve(
- info,
- net::DEFAULT_PRIORITY,
- &addresses_,
- base::Bind(&ResolveCompletionCallback),
- NULL,
- net_log_);
+ result_ = host_resolver_->Resolve(info, net::DEFAULT_PRIORITY, &addresses_,
+ base::Bind(&ResolveCompletionCallback),
+ &request_, net_log_);
}
void SetDefaultIPConfigs(const std::string& default_device_path) {
@@ -150,6 +146,7 @@ class HostResolverImplChromeOSTest : public testing::Test {
std::unique_ptr<net::HostResolver> host_resolver_;
base::MessageLoop io_message_loop_;
net::BoundNetLog net_log_;
+ std::unique_ptr<net::HostResolver::Request> request_;
DISALLOW_COPY_AND_ASSIGN(HostResolverImplChromeOSTest);
};

Powered by Google App Engine
This is Rietveld 408576698