Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 2116793002: Work around for private names in mixin applications. (Closed)

Created:
4 years, 5 months ago by ahe
Modified:
4 years, 4 months ago
Reviewers:
kasperl, kustermann
CC:
rasta-dart+reviews_googlegroups.com, kustermann, asgerf
Base URL:
git@github.com:dart-lang/rasta.git@master
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased on CL 2201763003. #

Total comments: 7

Patch Set 3 : Don't use @ in synthetic names. #

Patch Set 4 : Update test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -84 lines) Patch
M lib/kernel.dart View 1 2 3 chunks +12 lines, -10 lines 0 comments Download
M lib/kernel_visitor.dart View 1 2 8 chunks +15 lines, -7 lines 0 comments Download
M test/kernel/regression/issue_000081.dart.txt View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M test/kernel/regression/mixin_library.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M test/kernel/regression/mixin_library.dart.txt View 1 2 3 1 chunk +9 lines, -3 lines 0 comments Download
M test/kernel/regression/parser_error.dart.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/kernel/regression/static.dart.txt View 1 2 3 2 chunks +12 lines, -12 lines 0 comments Download
M test/kernel/regression/super.dart.txt View 1 2 3 13 chunks +36 lines, -36 lines 0 comments Download
M test/kernel/regression/super_mixin.dart.txt View 1 2 3 4 chunks +20 lines, -4 lines 0 comments Download
M test/kernel/regression/super_operator.dart.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/kernel/regression/type_with_parse_error.dart.txt View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M test/kernel/regression/unresolved.dart.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/kernel/regression/unresolved_constructor.dart.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/kernel/regression/unresolved_for_in.dart.txt View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (4 generated)
ahe
4 years, 5 months ago (2016-07-01 14:28:36 UTC) #2
ahe
ping
4 years, 4 months ago (2016-08-01 10:16:23 UTC) #3
kustermann
https://codereview.chromium.org/2116793002/diff/20001/lib/kernel.dart File lib/kernel.dart (right): https://codereview.chromium.org/2116793002/diff/20001/lib/kernel.dart#newcode146 lib/kernel.dart:146: name = "$name@${element.library.libraryOrScriptName}"; I landed a modified version of ...
4 years, 4 months ago (2016-08-01 10:37:39 UTC) #5
ahe
https://codereview.chromium.org/2116793002/diff/20001/lib/kernel.dart File lib/kernel.dart (right): https://codereview.chromium.org/2116793002/diff/20001/lib/kernel.dart#newcode146 lib/kernel.dart:146: name = "$name@${element.library.libraryOrScriptName}"; On 2016/08/01 10:37:39, kustermann wrote: > ...
4 years, 4 months ago (2016-08-01 10:44:42 UTC) #6
kustermann
https://codereview.chromium.org/2116793002/diff/20001/lib/kernel.dart File lib/kernel.dart (right): https://codereview.chromium.org/2116793002/diff/20001/lib/kernel.dart#newcode146 lib/kernel.dart:146: name = "$name@${element.library.libraryOrScriptName}"; On 2016/08/01 10:44:41, ahe wrote: > ...
4 years, 4 months ago (2016-08-01 11:23:39 UTC) #7
kasperl
LGTM with a (hopefully) helpful comment: https://codereview.chromium.org/2116793002/diff/20001/lib/kernel.dart File lib/kernel.dart (right): https://codereview.chromium.org/2116793002/diff/20001/lib/kernel.dart#newcode146 lib/kernel.dart:146: name = "$name@${element.library.libraryOrScriptName}"; ...
4 years, 4 months ago (2016-08-02 06:17:44 UTC) #8
ahe
Thank you. With @ flutter-aot-jit crashes, with :: it doesn't (when bootstrapping dart2js). https://codereview.chromium.org/2116793002/diff/20001/lib/kernel.dart File ...
4 years, 4 months ago (2016-08-02 11:09:10 UTC) #10
ahe
Committed patchset #4 (id:80001) manually as a9f39d2b2d589814f6a4f822afe4fd41d8bf13af (presubmit successful).
4 years, 4 months ago (2016-08-02 11:17:06 UTC) #12
kustermann
The name mangling cause an issue in the following case (and the mangling shouldn't be ...
4 years, 4 months ago (2016-08-02 14:26:33 UTC) #13
ahe
4 years, 4 months ago (2016-08-03 11:17:17 UTC) #14
Message was sent while issue was closed.
On 2016/08/02 14:26:33, kustermann wrote:
> The name mangling cause an issue in the following case (and the mangling
> shouldn't be necessary):

Thank you, Martin. I fixed that in https://codereview.chromium.org/2205943003.

Powered by Google App Engine
This is Rietveld 408576698