Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2194163002: Change default binary file extension to .dill (Closed)

Created:
4 years, 4 months ago by ahe
Modified:
4 years, 4 months ago
Reviewers:
asgerf, kasperl, kustermann
CC:
rasta-dart+reviews_googlegroups.com, kasperl
Base URL:
git@github.com:dart-lang/rasta.git@private_names
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Change default binary file extension to .dill (Landing CL 2159263002 on master) R=asgerf@google.com, kasperl@google.com Committed: https://github.com/dart-lang/rasta/commit/47f575a073f4b28c3798e1b22098664ee737e6b8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use constants for file extensions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M .gitignore View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/run_batch.dart View 1 chunk +1 line, -1 line 0 comments Download
M submodules.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/kernel/kernel_test.dart View 1 4 chunks +14 lines, -9 lines 0 comments Download

Depends on Patchset:

Issue 2116793002 Patch 80001

Dependent Patchsets:

Issue 2207473003 Patch 20001
Issue 2207473003 Patch 40001

Messages

Total messages: 8 (3 generated)
ahe
4 years, 4 months ago (2016-08-01 10:28:41 UTC) #2
asgerf
lgtm
4 years, 4 months ago (2016-08-01 10:42:56 UTC) #3
kasperl
LGTM. https://codereview.chromium.org/2194163002/diff/1/test/kernel/kernel_test.dart File test/kernel/kernel_test.dart (right): https://codereview.chromium.org/2194163002/diff/1/test/kernel/kernel_test.dart#newcode54 test/kernel/kernel_test.dart:54: tests[regression.uri] = temp.resolve("${regression.shortName}.dill"); It's almost like you should ...
4 years, 4 months ago (2016-08-02 06:26:12 UTC) #5
ahe
Thank you! https://codereview.chromium.org/2194163002/diff/1/test/kernel/kernel_test.dart File test/kernel/kernel_test.dart (right): https://codereview.chromium.org/2194163002/diff/1/test/kernel/kernel_test.dart#newcode54 test/kernel/kernel_test.dart:54: tests[regression.uri] = temp.resolve("${regression.shortName}.dill"); On 2016/08/02 06:26:12, kasperl ...
4 years, 4 months ago (2016-08-02 11:36:48 UTC) #6
ahe
4 years, 4 months ago (2016-08-02 11:38:14 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
47f575a073f4b28c3798e1b22098664ee737e6b8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698