third_party/WebKit/Source/core/inspector/MainThreadDebugger.h - Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase after ExceptionDetails change Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ExecutionContext.cpp ('k') | third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

index f2af18bb05f828cb79e3760f4a597e74fd5b5857..9c649e4c46cbbe0570ba0abf833fc32f781720cc 100644

--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

@@ -43,6 +43,7 @@ namespace blink {

class LocalFrame;

class SecurityOrigin;

+class SourceLocation;

class CORE_EXPORT MainThreadDebugger final : public ThreadDebugger {

WTF_MAKE_NONCOPYABLE(MainThreadDebugger);

@@ -64,10 +65,12 @@ public:

InspectorTaskRunner* taskRunner() const { return m_taskRunner.get(); }

bool isWorker() override { return false; }

void setClientMessageLoop(std::unique_ptr<ClientMessageLoop>);

+ // TODO(dgozman): by making this method virtual, we can move many methods to ThreadDebugger and avoid some duplication. Should be careful about performance.

int contextGroupId(LocalFrame*);

void didClearContextsForFrame(LocalFrame*);

void contextCreated(ScriptState*, LocalFrame*, SecurityOrigin*);

void contextWillBeDestroyed(ScriptState*);

+ void exceptionThrown(LocalFrame*, const String& errorMessage, std::unique_ptr<SourceLocation>);

void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override;