third_party/WebKit/Source/bindings/templates/interface_base.cpp - Issue 2116533003: [Origin Trials] Allow static attributes to be defined on origin trials

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp

Issue 2116533003: [Origin Trials] Allow static attributes to be defined on origin trials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix it harder Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_attributes.py ('k') | third_party/WebKit/Source/bindings/tests/idls/modules/TestInterfacePartial4.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp b/third_party/WebKit/Source/bindings/templates/interface_base.cpp

index a04553663d6cddc66cdfef4faa90baef0f9c9350..7f93dd3159ad842faaa9cd1cf495aafe4d43fdb0 100644

--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp

+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp

@@ -381,11 +381,9 @@ void {{v8_class_or_partial}}::install{{origin_trial_feature_name}}(ScriptState*

v8::Local<v8::Signature> signature = v8::Signature::New(scriptState->isolate(), interfaceTemplate);

ALLOW_UNUSED_LOCAL(signature);

{% endif %}

- {% if constants | for_origin_trial_feature(origin_trial_feature_name) or

- methods | method_for_origin_trial_feature(origin_trial_feature_name, is_partial) %}

V8PerContextData* perContextData = V8PerContextData::from(scriptState->context());

v8::Local<v8::Function> interface = perContextData->constructorForType(&{{v8_class}}::wrapperTypeInfo);

- {% endif %}

+ ALLOW_UNUSED_LOCAL(interface);

{% for attribute in attributes | for_origin_trial_feature(origin_trial_feature_name) | unique_by('name') | sort %}

{% if attribute.is_data_type_property %}

const V8DOMConfiguration::AttributeConfiguration attribute{{attribute.name}}Configuration = \

@@ -394,7 +392,7 @@ void {{v8_class_or_partial}}::install{{origin_trial_feature_name}}(ScriptState*

{% else %}

const V8DOMConfiguration::AccessorConfiguration accessor{{attribute.name}}Configuration = \

{{attribute_configuration(attribute)}};

- V8DOMConfiguration::installAccessor(scriptState->isolate(), scriptState->world(), instance, prototype, v8::Local<v8::Function>(), signature, accessor{{attribute.name}}Configuration);

+ V8DOMConfiguration::installAccessor(scriptState->isolate(), scriptState->world(), instance, prototype, interface, signature, accessor{{attribute.name}}Configuration);

{% endif %}

{% endfor %}

{# Origin-Trial-enabled constants #}