third_party/WebKit/Source/bindings/tests/idls/modules/TestInterfacePartial4.idl - Issue 2116533003: [Origin Trials] Allow static attributes to be defined on origin trials

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/idls/modules/TestInterfacePartial4.idl

Issue 2116533003: [Origin Trials] Allow static attributes to be defined on origin trials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix it harder Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/interface_base.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/idls/modules/TestInterfacePartial4.idl

diff --git a/third_party/WebKit/Source/bindings/tests/idls/modules/TestInterfacePartial4.idl b/third_party/WebKit/Source/bindings/tests/idls/modules/TestInterfacePartial4.idl

index d84829b8d1f098c6ef5cfa6fb583320267c4cb28..7071777a48b34f629474e05d06c4d80ab74cdd66 100644

--- a/third_party/WebKit/Source/bindings/tests/idls/modules/TestInterfacePartial4.idl

+++ b/third_party/WebKit/Source/bindings/tests/idls/modules/TestInterfacePartial4.idl

@@ -12,8 +12,7 @@

const unsigned short PARTIAL4_UNSIGNED_SHORT = 4;

attribute long partial4LongAttribute;

- // TODO(chasej): Uncomment when static attributes are supported for origin trials (crbug.com/614352)

- //static attribute long partial4StaticLongAttribute;

+ static attribute long partial4StaticLongAttribute;

// TODO(chasej): Uncomment when methods are supported for origin trials (crbug.com/621641)

void partial4VoidMethod();