Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

Issue 2116533003: [Origin Trials] Allow static attributes to be defined on origin trials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix it harder Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_attributes.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
index 2b1a8c9b35d70fcb0e2c90bc7581ff2319f9e4d5..7e86b2b45820866bc49c40b011e1b2ed37eadc86 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
@@ -182,13 +182,6 @@ def attribute_context(interface, attribute):
if not has_custom_setter(attribute) and has_setter(interface, attribute):
setter_context(interface, attribute, context)
- # [OriginTrialEnabled]
- # TODO(iclelland): Allow origin trials on static interfaces
- # (crbug.com/614352)
- if context['origin_trial_feature_name'] and context['on_interface']:
- raise Exception('[OriginTrialEnabled] cannot be specified on static '
- 'attributes: %s.%s' % (interface.name, attribute.name))
-
return context

Powered by Google App Engine
This is Rietveld 408576698